Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(visual regresion): notification font size #1941

Merged
merged 1 commit into from
Jul 23, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ui/client/bootstrap.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import {NkThemeProvider} from "./containers/theme"
import history from "./history"
import "./i18n"
import configureStore from "./store/configureStore"
import "./stylesheets/notifications.styl"

const {store, persistor} = configureStore()
const rootContainer = document.createElement(`div`)
Expand Down
30 changes: 0 additions & 30 deletions ui/client/components/notifications/Notification.js

This file was deleted.

29 changes: 29 additions & 0 deletions ui/client/components/notifications/Notification.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
import {isEmpty} from "lodash"
import React from "react"
import Dotdotdot from "react-dotdotdot"
import InlinedSvgs from "../../assets/icons/InlinedSvgs"
import HeaderIcon from "../tips/HeaderIcon"
import classnames from "./notifications.styl"

interface Props {
icon: string,
message?: string,
details?: string,
}

export default function Notification({icon, message, details}: Props): JSX.Element {
return (
<div className={classnames.notification}>
<div className="icon" dangerouslySetInnerHTML={{__html: icon}}/>
<div className={classnames.notificationDetails}>
{!isEmpty(message) && <span className={classnames.notificationText}>{message}</span>}
{!isEmpty(details) && (
<Dotdotdot clamp={`380px`}>
<span className={classnames.notificationText}>{details}</span>
</Dotdotdot>
)}
</div>
<HeaderIcon className={classnames.dismissIcon} icon={InlinedSvgs.tipsClose}/>
</div>
)
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@import "./_variables.styl"
@import "../../stylesheets/_variables.styl"

.notifications-wrapper
position absolute
Expand All @@ -11,7 +11,7 @@
width: 300px
max-height 400px
font-family "Open Sans"
font-size: 16
font-size: 16px
display flex
border 1px solid #3a3a3a
color #333333
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.