Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delay removing junk script tag after load #1929

Merged
merged 1 commit into from
Jul 21, 2021
Merged

fix: delay removing junk script tag after load #1929

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions ui/client/containers/ExternalLib/tools/createScript.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,17 @@
import {ScriptUrl} from "../types"

export function createScript(url: ScriptUrl): Promise<void> {
// eslint-disable-next-line i18next/no-literal-string
const element = document.createElement("script")
const promise = new Promise<void>((resolve, reject) => {
const element = document.createElement(`script`)

return new Promise<void>((resolve, reject) => {
element.src = url
element.type = "text/javascript"
element.async = true

element.onload = () => {
resolve()
// setTimeout to ensure full init (e.g. relying on document.currentScript etc) before remove
setTimeout(() => document.head.removeChild(element))
}

element.onerror = () => {
Expand All @@ -19,11 +21,5 @@ export function createScript(url: ScriptUrl): Promise<void> {

document.head.appendChild(element)

}).finally(() => cleanup())

const cleanup = () => {
document.head.removeChild(element)
}

return promise
})
}