Avro sink enhancements #1515
Merged
Avro sink enhancements #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nadberezny
commented
Apr 9, 2021
- Remove unnecessary parameter: ValidationMode
- Refactor: pass transformation state instead of var mutation
mproch
reviewed
Apr 12, 2021
| val key = params(SinkKeyParamName).asInstanceOf[LazyParameter[CharSequence]] | ||
|
|
||
| new KafkaAvroSink(preparedTopic, versionOption, key, sinkValue, kafkaConfig, schemaRegistryProvider.serializationSchemaFactory, | ||
| schemaData.serializableSchema, schemaUsedInRuntime.map(_.serializableSchema), clientId, validationMode) | ||
| schemaData.serializableSchema, schemaUsedInRuntime.map(_.serializableSchema), clientId, ValidationMode.strict) |
There was a problem hiding this comment.
I wonder, does it have any effect/causes problem when "Latest version" is chosen? E.g. when we want to handle compatible changes?
There was a problem hiding this comment.
I don't see issue with it. The idea is that our schema evolution mechanism handle this situation. From user perspective he/she should see definition of latest version. I see other problem - with handling defaults but will left comment in the place where it exists.
e7227da to
adfd312
Compare
1. Pass state instead of mutation
adfd312 to
cc181da
Compare
arkadius
approved these changes
Apr 19, 2021
This was referenced Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.