Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: FlinkSource API and test source API. #1510

Merged
merged 10 commits into from
Apr 12, 2021
Merged

Refactoring: FlinkSource API and test source API. #1510

merged 10 commits into from
Apr 12, 2021

Conversation

gskrobisz
Copy link
Member

No description provided.

@gskrobisz gskrobisz linked an issue Apr 8, 2021 that may be closed by this pull request
Source should be able to control start variables #548
Closed
arkadius
arkadius reviewed Apr 9, 2021
View reviewed changes
Copy link
Member

@arkadius arkadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change, some comments added.

...i/src/main/scala/pl/touk/nussknacker/engine/flink/util/context/FlinkContextInitializer.scala Outdated
*/
abstract class FlinkContextInitializer[T] extends Serializable {

def validationContext(context: ValidationContext, name: String, result: typing.TypingResult)(implicit nodeId: NodeId): ValidationContext
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Why we need this name here? Is it a name in case when we produce only one variable?
  2. Why we need result here? What is it?
  3. Shouldn't both be passed as a parameters of constructor in very specific case whene source produces only one variable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 & 2. Changed name -> outputVariableName and result -> outputVariableType and fixed documentation. Those parameters represent default one variable produced by the source.
3. For multiple variables see GenericSourceWithCustomVariablesSample. There is one val customContextInitilalizer which is used in two places:

  • creating the source
  • contextTransformation - This is the place where I know all variables and their types (especially in avro sources), and pass them as parameters to the method of already created object.
    I see two alternatives:
  1. pass a List of variable name-and-type pairs
  2. initialize var customContextInitilalizer with new FlinkContextInitializer inside contextTransformation
    WDYT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I see now. WDYT about passing to this validationContext method everything what we have in TransformationStep? I know that there are type dependent types but we can have parameters: List[(String, BaseDefinedParameter)], state: Option[Any] and someone could do some pattern matching on it. WDYT? Thanks to that we will have the whole power of GenericNodeTransformation in this place.

arkadius
arkadius reviewed Apr 9, 2021
View reviewed changes
...i/src/main/scala/pl/touk/nussknacker/engine/flink/util/context/FlinkContextInitializer.scala Outdated
*/
abstract class FlinkContextInitializer[T] extends Serializable {

def validationContext(context: ValidationContext, name: String, result: typing.TypingResult)(implicit nodeId: NodeId): ValidationContext
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I see now. WDYT about passing to this validationContext method everything what we have in TransformationStep? I know that there are type dependent types but we can have parameters: List[(String, BaseDefinedParameter)], state: Option[Any] and someone could do some pattern matching on it. WDYT? Thanks to that we will have the whole power of GenericNodeTransformation in this place.

@gskrobisz gskrobisz merged commit c386f63 into staging Apr 12, 2021
@dswiecki dswiecki deleted the improvements/flinksource_api_refactoring branch July 21, 2021 16:39
@snyk-bot snyk-bot mentioned this pull request Sep 21, 2021
Open
This was referenced Oct 6, 2022
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkadius arkadius arkadius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source should be able to control start variables
2 participants
@gskrobisz @arkadius