Publish standalone/app as docker image #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkadius
reviewed
Apr 7, 2021
engine/standalone/app/src/universal/bin/nussknacker-standalone-entrypoint.sh
Outdated
Show resolved
Hide resolved
mproch
reviewed
Apr 7, 2021
| } | ||
|
|
||
| lazy val distDockerSettings = { | ||
| val workingDir = "/opt/nussknacker" |
There was a problem hiding this comment.
workingDir, defaultLinuxInstallLocation and exposedVolumes can be in common?
There was a problem hiding this comment.
Well, after Arek's comments I added a /processes volume specific to standalone. So now exposedVolumes is not the same for both images. Plus I need workingDir to construct entrypoint path, which is specific for each image.
As for defaultLinuxInstallLocation it probably could, or even should be common. But it depends on workingDir, so I'd have to either make it a global constant in the file or define common settings as a function of workingDir instead of a simple Seq. Do you think it's worth it?
arkadius
reviewed
Apr 7, 2021
4b15fcb to
7641471
Compare
arkadius
reviewed
Apr 7, 2021
engine/standalone/app/src/universal/bin/nussknacker-standalone-entrypoint.sh
Outdated
Show resolved
Hide resolved
This was referenced Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.