Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Handling multiple schedules in periodic manager - first version #1497

Merged
merged 6 commits into from
Apr 13, 2021

Conversation

mproch
Copy link
Collaborator

@mproch mproch commented Mar 30, 2021

It's possible to define multiple named schedules (e.g. run with different parameters). Currently we don't handle running multiple Flink jobs with same ProcessName well, so there is limitation - we schedule only one process simultaneously (other schedules for same process have to wait).

@mproch mproch force-pushed the preview/multiple_schedules branch from 34799cf to 04e52c7 Compare March 30, 2021 05:38
Copy link
Contributor

@lciolecki lciolecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please look for my comments.

@mproch mproch force-pushed the preview/multiple_schedules branch 6 times, most recently from 95fdfd4 to 5b7bdea Compare April 7, 2021 05:44
@mproch mproch marked this pull request as ready for review April 7, 2021 05:51
@mproch mproch force-pushed the preview/multiple_schedules branch from 5b7bdea to cc3aab1 Compare April 7, 2021 05:54
@mproch mproch changed the title [Feature] Handling multiple schedules in periodic manager [Feature] Handling multiple schedules in periodic manager - first version Apr 7, 2021
Copy link
Member

@arkadius arkadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one naming issue I've found. I know that it will need some migration but IMO it will cost us less if we do it now then spend time talking why it is named that way.

Copy link
Member

@arkadius arkadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's someone with more production experiences take a look

@mproch mproch force-pushed the preview/multiple_schedules branch from 90ef8e7 to 35b2a66 Compare April 13, 2021 05:42
@mproch mproch force-pushed the preview/multiple_schedules branch from 419ac40 to 2398c2c Compare April 13, 2021 06:49
Copy link
Collaborator

@gadomsky gadomsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants