Skip to content

Commit

Permalink
fix: delay removing junk script tag after load (#1929)
Browse files Browse the repository at this point in the history
  • Loading branch information
JulianWielga authored Jul 21, 2021
1 parent c2d9e6d commit 6c99b50
Showing 1 changed file with 6 additions and 10 deletions.
16 changes: 6 additions & 10 deletions ui/client/containers/ExternalLib/tools/createScript.ts
Original file line number Diff line number Diff line change
@@ -1,15 +1,17 @@
import {ScriptUrl} from "../types"

export function createScript(url: ScriptUrl): Promise<void> {
// eslint-disable-next-line i18next/no-literal-string
const element = document.createElement("script")
const promise = new Promise<void>((resolve, reject) => {
const element = document.createElement(`script`)

return new Promise<void>((resolve, reject) => {
element.src = url
element.type = "text/javascript"
element.async = true

element.onload = () => {
resolve()
// setTimeout to ensure full init (e.g. relying on document.currentScript etc) before remove
setTimeout(() => document.head.removeChild(element))
}

element.onerror = () => {
Expand All @@ -19,11 +21,5 @@ export function createScript(url: ScriptUrl): Promise<void> {

document.head.appendChild(element)

}).finally(() => cleanup())

const cleanup = () => {
document.head.removeChild(element)
}

return promise
})
}

0 comments on commit 6c99b50

Please sign in to comment.