Configuration object and partial validation #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good in principle. Unfortunately we have made conflicting changes since 1.1 and I have committed those to master yesterday. The conflict is in ValidationUtil. Would you be able to merge this on your side and do a new PR? |
e7642c1 to
678b086
Compare
|
Sure, rebased over current master. |
ashleycaselli
added a commit
that referenced
this pull request
May 21, 2024
…lugins-maven-jar-plugin-3.x build(deps): update dependency org.apache.maven.plugins:maven-jar-plugin to v3.4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a configuration option for the validation engine making it possible to stop the evaluation of the constraints, once a maximum number of errors have been reached.
The use case for this behaviour is situations where we just need to know if the data graph is valid or not, regardless of the total number of errors. For example, where providing a validity service where we want to maximise the performance of the service and where failing fast is preferred to getting the complete set of validation errors.
To make it possible to configure this behaviour, a configuration object has been introduced where this option (and other future options) can be set-up.
Matching JS change: TopQuadrant/shacl-js#16