Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes #12

Merged
merged 3 commits into from
Sep 26, 2017
Merged

Misc fixes #12

merged 3 commits into from
Sep 26, 2017

Conversation

antoniogarrote
Copy link
Contributor

  • Improved TermFactory with better support for literals
  • Fixed problem with initial value of the StartQuery iterator

Pending sync with Java library

@HolgerKnublauch
Copy link
Collaborator

Given the failures above, I assume this is still work in progress?

@HolgerKnublauch
Copy link
Collaborator

BTW there are slight changes to dash.js and dash.ttl at TopQuadrant/shacl@bf00c3c

When copying dash.ttl note that the references to tosh need to be removed for the version bundled with shacl-js (3 lines).

@antoniogarrote
Copy link
Contributor Author

antoniogarrote commented Sep 26, 2017

The problem was the sync check in the build. If it finds a different version of the shared ttl or js files the build fails automatically.
It will always happen if I make changes in one file and they are not yet merged into master in the Java project.

I have removed the references to tosh from dash.ttl. You already removed the sync check for that particular file.

I have made a small test re-writing rdfquery in typescript:
https://github.com/antoniogarrote/rdfquery-standalone

Wondering if having a stand-alone version of rdfquery that can be referenced from both projects is a direction you would like to explore. It might make the full process of managing changes in the common dependency easier. Also adding some static typing on the library is a nice add-on.

@HolgerKnublauch HolgerKnublauch merged commit aa4aa5f into master Sep 26, 2017
@HolgerKnublauch
Copy link
Collaborator

I have not used typescript but I do agree with the benefits of strong typing. rdfquery had always been conceived to be potentially stand-alone. It's a simple library that may be of general use. If you think it would be worthwhile doing this separation, then go ahead, but I may not be able to help much on this given my other commitments and being more on the Java side of things. As long as there is an easy way to get the necessary .js file(s) so that I can copy it over into the other projects, and as long as the test cases still pass, I am fine.

@antoniogarrote antoniogarrote deleted the misc_fixes branch May 21, 2018 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants