Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Moved assets to template #5

Merged
merged 4 commits into from
Nov 29, 2024
Merged

Feature: Moved assets to template #5

merged 4 commits into from
Nov 29, 2024

Conversation

rhouthuijzen
Copy link
Collaborator

No description provided.

@rhouthuijzen
Feature: Moved assets to template

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
52ce294
@rhouthuijzen rhouthuijzen linked an issue Oct 2, 2024 that may be closed by this pull request
query topdesk assets configurable per template #4
Closed
@rhouthuijzen rhouthuijzen added the needs-review Indicates that the PR is ready and waiting for review label Oct 2, 2024
@rhouthuijzen
Feature: updated configuration for assets

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
4a75ffa
@rhouthuijzen
Feature: update readme

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
dc0a252
@rhouthuijzen
Feature: Added support for 'skipNoAssetsFound'

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
550cca0
rschouten97
rschouten97 requested changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@rschouten97 rschouten97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, however I am unable to test this.
Has this been tested successfully? If so, please let me know and I will approve the PR.

@rschouten97 rschouten97 added pending-author-update PR is waiting for the author to make necessary modifications or updates and removed needs-review Indicates that the PR is ready and waiting for review labels Nov 22, 2024
@JeroenBL JeroenBL removed the pending-author-update PR is waiting for the author to make necessary modifications or updates label Nov 29, 2024
@rhouthuijzen rhouthuijzen merged commit e31a4f4 into main Nov 29, 2024
@rhouthuijzen rhouthuijzen deleted the feature-moved-assets-to-template branch November 29, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschouten97 rschouten97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

query topdesk assets configurable per template
3 participants
@rhouthuijzen @rschouten97 @JeroenBL