-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support to the new mesh format of atoms 3 #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @iaiotom. I only left a couple notes here. I'm sure you know more than I do regarding all the Atoms API changes. One thing I'd like though is more thorough testing, since we're not too familiar with the changes on your side, it'd be great to have higher confidence that these changes are going to (a) keep our existing shots rendering the same and (b) improve the experience with the newly cached data. In particular I'd like to see some testes verifying that the Sets are coming through now, and that the transform matrices, bounds, and mesh positions are all in the expected spaces.
…t issue-23, updated assets for new mesh format, updated tests for new assets, added uv indices issue-27
I've added the tests for the last features I've added |
ACS-111 fix |
Thanks @iaiotom ! Confirmed this fixes several issues on our end. |
This will handle the new mesh format and also the old one at the same time. The old mesh are converted to the new format at loading time.