Build improvements #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We found we were making several build mistakes by suppressing the commands.
We can't fix compilation warnings upstream, so might as well suppress them.
When building with ATOMS_MAYA_ROOT we need to be able to specify which Maya we're targetting.
This should now be specified in the build args (via -DCMAKE_CXX_FLAGS). The README has been updated accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes we motivated by my attempts to debug a crash when using AtomsGaffer inside Maya 2019. It turns out to be unrelated, but I think they're an improvement in any case.
Build
-DCMAKE_CXX_FLAGS='-std=c++11').MAYA_MAJOR_VERSIONarg (only used ifATOMS_MAYA_ROOTis specified).-isystemfor upstream includes.