Bump lru-cache and provide dispose() method
#325
Conversation
Bumping the dependency is just a drive-by; this is mostly for making sure that `Agent` instances in the cache are destroyed when no longer reachable.
🦋 Changeset detectedLatest commit: 110efed The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@TooTallNate I'm going through and reviewing some PRs. Do you know why some of them are not including any CI checks besides the Vercel deployment? |
| @@ -36,7 +36,7 @@ | |||
| "debug": "^4.3.4", | |||
| "http-proxy-agent": "^7.0.1", | |||
| "https-proxy-agent": "^7.0.5", | |||
| "lru-cache": "^7.14.1", | |||
| "lru-cache": "^11.0.0", | |||
There was a problem hiding this comment.
lru-cache@11 supports Node 20 || >= 22: https://github.com/isaacs/node-lru-cache/blob/65c9971e3fef123ff0f17d67add53b2d99b461b0/package.json#L70
So updating lru-cache would require a major version bump. But dispose is available in v7 (isaacs/node-lru-cache@7a6f529) so I think its better to revert the dep update and save it for the next major.
Bumping the dependency is just a drive-by; this is mostly for making sure that
Agentinstances in the cache are destroyed when no longer reachable.