Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use eqt FormDialog #318

Merged
merged 3 commits into from
Jul 29, 2024
Merged

use eqt FormDialog #318

merged 3 commits into from
Jul 29, 2024

Conversation

paskino
Copy link
Contributor

@paskino paskino commented Jul 8, 2024 •
edited
Loading

  • Uses EQT FormDialog which automatically handles OK and Cancel button.
  • saves instance of the dialog in the main app and launches that one if required, preventing multiple such dialogs to be launched at the same time.
  • closes Settings dialog can be opened multiple times #317

@paskino paskino requested a review from DanicaSTFC July 8, 2024 17:10
DanicaSTFC
DanicaSTFC approved these changes Jul 29, 2024
View reviewed changes
src/idvc/dvc_interface.py
@@ -181,6 +182,7 @@ def __init__(self):

self.SetAppStyle()

self.settings_window = SettingsWindow(self)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the creation of the dialog in init.

@paskino paskino merged commit b986d67 into master Jul 29, 2024
3 checks passed
@paskino paskino deleted the fix_setting_window branch July 29, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanicaSTFC DanicaSTFC DanicaSTFC approved these changes

Assignees

@paskino paskino

Labels
None yet
Projects
iDVC Planning
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Settings dialog can be opened multiple times
2 participants
@paskino @DanicaSTFC