Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector display in results tab #231

Merged
merged 24 commits into from
Jun 11, 2024
Merged

Vector display in results tab #231

merged 24 commits into from
Jun 11, 2024

Conversation

DanicaSTFC
Copy link
Contributor

@DanicaSTFC DanicaSTFC commented Apr 11, 2024

These have both been tested to be working correctly and displaying all vectors and points when the button "View vectors" is clicked. Probably this was a nice waterfall effect of #270.

  • Replaced "View vectors" with "View:"
  • Added extra lines (section) for viewing vectors and vector settings
  • Moved 'subvolume size' and 'points in subvolume'

TESTS:

  • Tested by running the app on magma data.
  • Tested the view point cloud, view vectors, the scaling vector, and min max values.

NOTES:

  • "On results panel, if you don't view pointcloud before viewing vectors, then the vectors do not display correctly." This does not seem to happen anymore.
  • It does NOT Remove "View pointcloud/vectors" button.
    The 'View' button is connected to _DVCResultsDisableRanges, hence it is tricky to delete the view button until the checker is removed. Opened issue about this.
  • Options underneath view vectors is STILL clickable if "View pointcloud" is selected. This is, again, not done because there is a checker on the min value which is tricky to remove.
  • all points are listed in the widget "points in point cloud". This is not true if the push button view vectors is removed.

@DanicaSTFC DanicaSTFC self-assigned this Apr 11, 2024
@DanicaSTFC DanicaSTFC marked this pull request as draft April 11, 2024 21:18
@DanicaSTFC DanicaSTFC added this to the Version 24.0.0 milestone May 2, 2024
@DanicaSTFC DanicaSTFC marked this pull request as ready for review June 11, 2024 10:45
@DanicaSTFC DanicaSTFC requested a review from paskino June 11, 2024 12:25
src/idvc/dvc_interface.py Outdated Show resolved Hide resolved
Co-authored-by: Edoardo Pasca <14138589+paskino@users.noreply.github.com>
@DanicaSTFC DanicaSTFC merged commit 0c429b7 into master Jun 11, 2024
3 checks passed
@DanicaSTFC DanicaSTFC deleted the vector-display branch June 11, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Not all vectors are displayed vector display after pointcloud
2 participants