-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor framework #1692
Refactor framework #1692
Conversation
… with calls to a TypedDict. Remaining bug with Partitioner import in 2 test cases.
…ry instead of AcquisitionGeometry.
… import ambiguity.
0b0e275
to
9423e47
Compare
Added a whole load of new commits to break framework.py into smaller files. Largest file is now only ~1900 lines long! |
SIRF tests run using Docker, and those have been amended so they pass (turned out there was a lot less stuff being imported from CIL than I'd thought). |
a1a209e
to
73cbdfa
Compare
ebc5ca4
to
96ec5ab
Compare
96928b5
to
818a1a4
Compare
I checked the documentation and it looks fine. I added the labels separately but can remove them if we don't want them in the user-facing docs. |
Have run a few of the iterative (folder 2) demo notebooks and all is fine there |
Congratulations @manchester-jhellier you are now 4th in the list! |
DataOrder
is densely coupled to things inframework.py
(especiallyDataContainer
). To alleviate this,{ImageGeometry,AcquisitionGeometry}.{CHANNEL,VERTICAL,...}
is replaced with withlabels.Enum
(fixes DataOrder is a problem and should be destroyed #1691)framework.py
into smaller pieces (fixes Break framework.py into smaller pieces #1686)@casperdcl checklist
labels
StrEnum
AcquisitionTypes
&AcquisitionDimensions
intoAcquisitionType(enum.Flag)
{get,check}_order_for_engine()
FillTypes
->FillType
etc.)tests
review checklist
Contribution Notes
Please read and adhere to the developer guide and local patterns and conventions.