Avoid processing own hashes (3x) (neo-project#1009)

* Avoid processing own hashes * Shargon's suggestion I * Shargon's suggestion II * rename
Tommo-L · Jun 22, 2020 · 39d4e70 · 39d4e70
1 parent b1f078d
commit 39d4e70
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/neo/IO/Caching/FIFOSet.cs b/neo/IO/Caching/FIFOSet.cs
@@ -41,6 +41,11 @@ public bool Add(T item)
             return true;
         }
 
+        public bool Contains(T item)
+        {
+            return dictionary.Contains(item);
+        }
+
         public void ExceptWith(IEnumerable<UInt256> hashes)
         {
             foreach (var hash in hashes)

diff --git a/neo/Network/P2P/ProtocolHandler.cs b/neo/Network/P2P/ProtocolHandler.cs
@@ -248,7 +248,7 @@ private void OnInventoryReceived(IInventory inventory)
 
         private void OnInvMessageReceived(InvPayload payload)
         {
-            UInt256[] hashes = payload.Hashes.Where(p => knownHashes.Add(p)).ToArray();
+            UInt256[] hashes = payload.Hashes.Where(p => knownHashes.Add(p) && !sentHashes.Contains(p)).ToArray();
             if (hashes.Length == 0) return;
             switch (payload.Type)
             {