This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
component のディレクトリ構成を変更 #2916
Closed
component のディレクトリ構成を変更 #2916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
83e1557 to
08068cb
Compare
08068cb to
872d90c
Compare
Conflicts: components/index/cards/charts/TestedNumberChart.vue
|
@halsk, @kaizumaki すみません，こちらレビュー頂けていないようですので，ご確認下さい．（たびたび conflict を起こしているので，いいタイミングで merge して頂きたいです） |
Merged
|
@nard-tech お待たせして申し訳ありません。グラフ・表に関する大きめのPRのマージを控えていることと、都から新規グラフ・表の追加の依頼がきている現状から、こちらのPRについてはタイミングを見計っている状況です。 |
|
@kaizumaki 承知しました．#3008 もしばらくそのままにしておいた方がよさそうですね． |
|
conflict が多すぎるため close し，新しく PR を作ることとします． cf. #4016 |
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👏 解決する issue / Resolved Issues
⛏ 変更内容 / Details of Changes
page/index.vueのみで使われているcomponents/以下のファイルを，components/index以下に移動する（components/flowと同様）components/cards/以下のファイルも，components/index/cards/に移動するcomponents/cards/でimportしている component（主にグラフ描画用のXxxxChart）をcomponents/index/cards/charts/に移動するDataTableはComfirmedCasesAttributesTableに，TimeStackedBarChartはTestedNumberBarChartに名前を変更するpage/flow.vueのみで使われているcomponents/以下のファイルを，components/flow以下に移動する（PrinterButtonのみ？）