Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Fix Physics Interpolation #611

Merged
merged 2 commits into from
Feb 2, 2025
Merged

[4.4] Fix Physics Interpolation #611

merged 2 commits into from
Feb 2, 2025

Conversation

TokisanGames
Copy link
Owner

@TokisanGames TokisanGames commented Feb 1, 2025

  • Moves all snapping to the physics frame (no apparent effect, but handling it in process isn't necessary)
  • Fixes physics interpolation by resetting it on the meshes

This fix requires a version of Terrain3D built against godot-cpp 4.4 and Godot Engine 4.4. The artifact in this build will work in 4.4 while its available. However, once this PR is merged into main, which is still running on godot-cpp 4.3, devs will have to build Terrain3D from source against godot-cpp 4.4 in order to use Physics Interpolation in 4.4. This will remain the case until we stop supporting 4.3.

Fixes #470

@TokisanGames TokisanGames added bug Something isn't working waiting for godot Bug or missing feature in the engine labels Feb 1, 2025
@TokisanGames TokisanGames removed the waiting for godot Bug or missing feature in the engine label Feb 1, 2025
@mrjustaguy
Copy link

I confirm the issue is Fixed 👍

@TokisanGames TokisanGames merged commit b78d159 into main Feb 2, 2025
15 checks passed
@TokisanGames TokisanGames deleted the physics-frame branch February 2, 2025 17:23
@TokisanGames
Copy link
Owner Author

There's also a main-godot4.4 branch for CI builds that will loosely track main but has 4.4 godot-cpp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Physics Interpolation Breaks Terrain
2 participants