Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifact along autoshader border #276

Closed
TokisanGames opened this issue Dec 15, 2023 · 2 comments
Closed

Artifact along autoshader border #276

TokisanGames opened this issue Dec 15, 2023 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@TokisanGames
Copy link
Owner

TokisanGames commented Dec 15, 2023

When far away, there's pixelated noise along the border between autoshaded and manually painted areas.

image

image

Looks similar to #244 and may be related or have the same cause.

@TokisanGames TokisanGames added the bug Something isn't working label Dec 15, 2023
@TokisanGames TokisanGames added this to the Beta milestone Dec 15, 2023
@TokisanGames TokisanGames moved this to 1.0-Stable Release in Terrain3D Roadmap Dec 15, 2023
@TokisanGames TokisanGames modified the milestones: Beta, Stable Dec 15, 2023
@TokisanGames
Copy link
Owner Author

This can be fixed by either removing the overlay shader optimization

if (out_mat.blend > 0.f) { 
to
if (true) {

Or by moving the secondary texture lookups into the main function scope, moving them before the if out_mat.blend>0.

vec4 albedo_ht2 = texture(...)
vec4 normal_rg2 = texture(...);
if (out_mat.blend > 0.f) {

@TokisanGames
Copy link
Owner Author

The above workarounds also fixes #244, so this is a duplicate. And both will be fixed with the latter as the branch does seem to still provide some optimization on my 3070.

@github-project-automation github-project-automation bot moved this from 1.0-Stable Release to Done in Terrain3D Roadmap Dec 16, 2023
@TokisanGames TokisanGames modified the milestones: Stable, Beta Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

1 participant