Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifacts in some textures when far and off-axis #244

Closed
TokisanGames opened this issue Nov 11, 2023 · 1 comment
Closed

Artifacts in some textures when far and off-axis #244

TokisanGames opened this issue Nov 11, 2023 · 1 comment
Labels
bug Something isn't working help wanted Help from other contributors desired
Milestone

Comments

@TokisanGames
Copy link
Owner

TokisanGames commented Nov 11, 2023

Terrain3D version

0.8.3

Godot version

4.1.3

System information

Windows 11/64, RTX 3070, Vulkan

Issue description

There's a strange artifact on some textures when viewed in the distance. It looks like textures need to be filtered. This is also present in #234 even after heavy restructuring of the shader.

Wavering on the left and pixelated on the right. This is mostly about the pixels.

Recording.2023-11-03.192038.mp4

The problem is related to the textures read with the albedo_height and normal_rough texture arrays. The samplers that read the textures do have filtering enabled.

uniform sampler2DArray texture_array_albedo : source_color, filter_linear_mipmap_anisotropic, repeat_enable;
uniform sampler2DArray texture_array_normal : hint_normal, filter_linear_mipmap_anisotropic, repeat_enable;

If anisotropic is disabled the artifacts are much worse because the surrounding ground is now blurry, and the pixelated ground strongly contrasts.

Recording.2023-11-12.004906.mp4

All textures are 2k and have mipmaps.

The artifact is in the albedo/height channels. Disabling texture normals doesn't change it. Disabling albedo and just viewing normals/rough it looks fine.

Clamping values on height or albedo doesn't affect it.

Logs

No response

@TokisanGames TokisanGames added bug Something isn't working help wanted Help from other contributors desired labels Nov 11, 2023
@TokisanGames TokisanGames added this to the Stable milestone Nov 11, 2023
@TokisanGames TokisanGames moved this to Stable Release in Terrain3D Roadmap Nov 11, 2023
@TokisanGames
Copy link
Owner Author

Solution found in #276.

@github-project-automation github-project-automation bot moved this from 1.0-Stable Release to Done in Terrain3D Roadmap Dec 16, 2023
@TokisanGames TokisanGames modified the milestones: Stable, Beta Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Help from other contributors desired
Projects
Status: Done
Development

No branches or pull requests

1 participant