style: use constexpr for max lod

TokisanGames · Jan 25, 2025 · a61e720 · a61e720
1 parent 237dc44
commit a61e720
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/terrain_3d_mesh_asset.cpp b/src/terrain_3d_mesh_asset.cpp
@@ -144,7 +144,7 @@ Terrain3DMeshAsset::Terrain3DMeshAsset() {
 	_name = "New Mesh";
 	_id = 0;
 
-	_lod_visibility_ranges.resize(4); // TODO: define this as const.
+	_lod_visibility_ranges.resize(MAX_LOD_COUNT);
 	_lod_visibility_ranges.fill(0.f);
 }
 
@@ -158,7 +158,7 @@ void Terrain3DMeshAsset::clear() {
 	_maximum_lod = 0;
 	_shadow_lod = 0;
 
-	_lod_visibility_ranges.resize(4); // TODO: define this as const.
+	_lod_visibility_ranges.resize(MAX_LOD_COUNT);
 	_lod_visibility_ranges.fill(0.f);
 
 	_generated_faces = 2.f;
@@ -213,7 +213,7 @@ void Terrain3DMeshAsset::set_cast_shadows(const GeometryInstance3D::ShadowCastin
 }
 
 void Terrain3DMeshAsset::set_maximum_lod(const int p_lod) {
-	_maximum_lod = CLAMP(p_lod, 0, MIN(3, get_mesh_count() - 1)); // TODO: use const, 3 is max lod - 1
+	_maximum_lod = CLAMP(p_lod, 0, MIN(MAX_LOD_COUNT - 1, get_mesh_count() - 1));
 	LOG(INFO, "Setting maximum LOD: ", _maximum_lod);
 	emit_signal("instancer_setting_changed");
 }
@@ -307,7 +307,7 @@ void Terrain3DMeshAsset::set_scene_file(const Ref<PackedScene> &p_scene_file) {
 			}
 			_meshes.push_back(mesh);
 
-			if (_meshes.size() == 4) { // TODO: make this a constant
+			if (_meshes.size() == MAX_LOD_COUNT) {
 				break;
 			}
 		}

diff --git a/src/terrain_3d_mesh_asset.h b/src/terrain_3d_mesh_asset.h
@@ -27,6 +27,8 @@ class Terrain3DMeshAsset : public Terrain3DAssetResource {
 	};
 
 private:
+	static constexpr int MAX_LOD_COUNT = 4;
+
 	// Saved data
 	real_t _height_offset = 0.f;
 	real_t _visibility_range = 100.f; // TODO: drop and discuss storage migration