Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take steps to prevent file access from Sandbox #22

Open
ynvaser opened this issue Feb 15, 2019 · 2 comments
Open

Take steps to prevent file access from Sandbox #22

ynvaser opened this issue Feb 15, 2019 · 2 comments
Assignees
@irufus
Labels
enhancement New feature or request

Comments

@ynvaser
Copy link

ynvaser commented Feb 15, 2019

Previous issue: #15
Seems like it's not enough.
I'd suggest running the app with a linux user that only has read/execute access to what it needs to.
I-Al-Istannen added a commit to I-Al-Istannen/JShellBot that referenced this issue Feb 16, 2019
@I-Al-Istannen
Fix regression Together-Java#22
3327c9a 
The security manager incorrectly assumed executed methods were his and
allowed unfiltered access
I-Al-Istannen added a commit to I-Al-Istannen/JShellBot that referenced this issue Feb 16, 2019
@I-Al-Istannen
Add regression tests for Together-Java#22
34e81ce
@I-Al-Istannen I-Al-Istannen mentioned this issue Feb 16, 2019
Merged
@I-Al-Istannen
Copy link
Contributor

Letting it run with reduced rights is still beneficial, but it can not prevent the bot from reading it's own token. Though adding a safeguard that blocks all executed code from reading a file in the bot directory would be possible.

@irufus irufus self-assigned this Mar 18, 2019
@irufus
Copy link
Contributor

irufus commented Mar 18, 2019

Leaving a note to close and split this into another issue.

@irufus irufus added the enhancement New feature or request label Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irufus irufus

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@irufus @I-Al-Istannen @ynvaser