Options page does not work with Chrome/Chromium

[tdulcet]

This code block does not work in Chrome/Chromium:

AutomaticSettings/internal/LoadAndSave.js

Lines 167 to 178 in 26c51c6

	return gettingOption.then((res) => {
	showManagedInfo();
	console.info("managed config found", res, elOption);
	// and disable control
	elOption.setAttribute("disabled", "");
	elOption.setAttribute("title", browser.i18n.getMessage("optionIsDisabledBecauseManaged"));
	// could also set readonly elOption.setAttribute("readonly", "") //TODO: test
	return applyOption(option, optionGroup, elOption, res);
	});

It causes all the settings to be identified as managed, which effectively disables the options page:

This is currently blocking Chrome support for the Awesome Emoji Picker and Unicodify. It is also blocking me from using this library in several other extensions I am developing, like Colab Autorun and Connect.

Originally posted in rugk/awesome-emoji-picker#4 (comment).

[rugk]

And I vaguely remember there was some Promise one should comment that would fix that bug. Did not you say something like that?

Anyway, thanks for reporting it here, which is certainly the appropriate place.

[tdulcet]

And I vaguely remember there was some Promise one should comment that would fix that bug. Did not you say something like that?

Yes, in rugk/awesome-emoji-picker#4 (comment). I said that developers can replace the above block with return Promise.reject();, which will make the options page work, but obviously disable the managed options feature.

[rugk]

So… let's better find the real issue and the real solution for that, don't we?

[tdulcet]

I investigated it several months ago and I believe the issue was that Firefox rejects the promise when a managed option is not found, but Chrome resolves it in that case, although just with an empty object...

[rugk]

Okay, then theoretically, #12 should fix the issue then (untested).

[tdulcet]

Yes, that works great! Thanks for fixing it. 👍

As expected, I do get some errors in the console, but they are probably better fixed with #11:

Also, the Unicodify options page is very skinny (compared to the Awesome Emoji Picker above), but it probably just needs some CSS :

[rugk]

Yeah, also that annoying wrap for helper texts becomes apparent there.
I've opened #17 now for that, as I just saw it was not tracked anywhere.