Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare imports as sorted array #862

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Compare imports as sorted array #862

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fbad45
Compare imports as sorted array
tinder-garricnahapetian Oct 7, 2024
0b32fa8
Use sortedImports
tinder-garricnahapetian Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
94 changes: 47 additions & 47 deletions Tests/NodesGeneratorTests/StencilTemplateTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ final class StencilTemplateTests: XCTestCase, TestFactories {
let config: Config = givenConfig()
for stencilTemplate in StencilTemplate.allCases {
for uiFramework in config.uiFrameworks {
let imports: Set<String> = stencilTemplate.imports(with: config, including: uiFramework)
let imports: [String] = Array(stencilTemplate.imports(with: config, including: uiFramework)).sorted()
let uiFrameworkImport: String
switch uiFramework.kind {
case .appKit:
Expand All @@ -276,93 +276,93 @@ final class StencilTemplateTests: XCTestCase, TestFactories {
]
case .builder:
expect(imports) == [
"Nodes",
"<baseImport>",
"<reactiveImport>",
"<builderImport>",
"<dependencyInjectionImport>",
"<builderImport>"
"<reactiveImport>",
"Nodes"
]
case .builderTests:
expect(imports) == [
"NodesTesting",
"<baseTestImport>"
"<baseTestImport>",
"NodesTesting"
]
case .context:
expect(imports) == [
"Nodes",
"<baseImport>",
"<reactiveImport>"
"<reactiveImport>",
"Nodes"
]
case .contextTests:
expect(imports) == [
"Nodes",
"<baseTestImport>",
"Nodes",
"NodesTesting"
]
case .flow:
expect(imports) == [
"Nodes",
"<baseImport>",
"<flowImport>"
"<flowImport>",
"Nodes"
]
case .flowTests:
expect(imports) == [
"<baseTestImport>"
]
case .plugin:
expect(imports) == [
"Nodes",
"<baseImport>",
"<dependencyInjectionImport>"
"<dependencyInjectionImport>",
"Nodes"
]
case .pluginTests:
expect(imports) == [
"NodesTesting",
"<baseTestImport>"
"<baseTestImport>",
"NodesTesting"
]
case .pluginList:
expect(imports) == [
"Nodes",
"<baseImport>",
"<dependencyInjectionImport>",
"<pluginListImport>"
"<pluginListImport>",
"Nodes"
]
case .pluginListTests:
expect(imports) == [
"NodesTesting",
"<baseTestImport>"
"<baseTestImport>",
"NodesTesting"
]
case .state:
expect(imports) == [
"<baseImport>"
]
case .viewController:
expect(imports) == [
"Nodes",
"<baseImport>",
"<reactiveImport>",
"<viewControllerImport>",
"Nodes",
uiFrameworkImport
]
].sorted()
case .viewControllerTests:
expect(imports) == [
"<baseTestImport>",
uiFramework.kind.isHostingSwiftUI ? "NodesTesting" : "<reactiveImport>"
]
case .viewState:
expect(imports) == [
"Nodes",
"<baseImport>"
"<baseImport>",
"Nodes"
]
case .viewStateFactoryTests:
expect(imports) == [
"<baseTestImport>"
]
case .worker:
expect(imports) == [
"Nodes",
"<baseImport>",
"<reactiveImport>"
"<reactiveImport>",
"Nodes"
]
case .workerTests:
expect(imports) == [
Expand All @@ -377,7 +377,7 @@ final class StencilTemplateTests: XCTestCase, TestFactories {
func testImportsWithConfig() {
let config: Config = givenConfig()
for stencilTemplate in StencilTemplate.allCases {
let imports: Set<String> = stencilTemplate.imports(with: config)
let imports: [String] = Array(stencilTemplate.imports(with: config)).sorted()
switch stencilTemplate {
case .analytics:
expect(imports) == [
Expand All @@ -389,60 +389,60 @@ final class StencilTemplateTests: XCTestCase, TestFactories {
]
case .builder:
expect(imports) == [
"Nodes",
"<baseImport>",
"<reactiveImport>",
"<builderImport>",
"<dependencyInjectionImport>",
"<builderImport>"
"<reactiveImport>",
"Nodes"
]
case .builderTests:
expect(imports) == [
"NodesTesting",
"<baseTestImport>"
"<baseTestImport>",
"NodesTesting"
]
case .context:
expect(imports) == [
"Nodes",
"<baseImport>",
"<reactiveImport>"
"<reactiveImport>",
"Nodes"
]
case .contextTests:
expect(imports) == [
"Nodes",
"<baseTestImport>"
"<baseTestImport>",
"Nodes"
]
case .flow:
expect(imports) == [
"Nodes",
"<baseImport>",
"<flowImport>"
"<flowImport>",
"Nodes"
]
case .flowTests:
expect(imports) == [
"<baseTestImport>"
]
case .plugin:
expect(imports) == [
"Nodes",
"<baseImport>",
"<dependencyInjectionImport>"
"<dependencyInjectionImport>",
"Nodes"
]
case .pluginTests:
expect(imports) == [
"NodesTesting",
"<baseTestImport>"
"<baseTestImport>",
"NodesTesting"
]
case .pluginList:
expect(imports) == [
"Nodes",
"<baseImport>",
"<dependencyInjectionImport>",
"<pluginListImport>"
"<pluginListImport>",
"Nodes"
]
case .pluginListTests:
expect(imports) == [
"NodesTesting",
"<baseTestImport>"
"<baseTestImport>",
"NodesTesting"
]
case .state:
expect(imports) == [
Expand All @@ -458,9 +458,9 @@ final class StencilTemplateTests: XCTestCase, TestFactories {
expect(imports).to(beEmpty())
case .worker:
expect(imports) == [
"Nodes",
"<baseImport>",
"<reactiveImport>"
"<reactiveImport>",
"Nodes"
]
case .workerTests:
expect(imports) == [
Expand Down
Loading