-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add state store mocks #849
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efa421c
to
5a5ffcf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on offline discussions, the decision is to add mocks similar to what this PR was initially introducing, but without the bind methods, as the bind methods will be removed from the protocols on another PR.
For reference:
StateStoreMock.swift
:
//
// Copyright © 2024 Tinder (Match Group, LLC)
//
import Nodes
import SwiftUI
public final class StateStoreMock<State: Equatable>: StateStore, ObservableStateStore {
public var state: State {
didSet { stateSetCallCount += 1 }
}
public private(set) var stateSetCallCount: Int = 0
public init(state: State) {
self.state = state
}
}
ViewStateStoreMock.swift
:
//
// Copyright © 2024 Tinder (Match Group, LLC)
//
import Nodes
import SwiftUI
public final class ViewStateStoreMock<ViewState: Equatable>: ViewStateStore, ObservableViewStateStore {
public var viewState: ViewState {
didSet { viewStateSetCallCount += 1 }
}
public private(set) var viewStateSetCallCount: Int = 0
public init(viewState: ViewState) {
self.viewState = viewState
}
}
tinder-cfuller
approved these changes
Oct 2, 2024
3ebe039
to
21e6e56
Compare
tinder-cfuller
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.