Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storePrefix to Config #838

Merged
merged 7 commits into from
Sep 23, 2024
Merged

Add storePrefix to Config #838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
680e7f5
Add isObservableStoreEnabled Config option
tinder-garricnahapetian Sep 12, 2024
c87da3d
Add storePrefix to Config
tinder-garricnahapetian Sep 13, 2024
b93229f
Add test
tinder-garricnahapetian Sep 13, 2024
1747c4a
Update TestFactories
tinder-garricnahapetian Sep 13, 2024
aab01a7
Fix bad rebase
tinder-garricnahapetian Sep 20, 2024
4e48e82
Improve test
tinder-garricnahapetian Sep 20, 2024
86c08d3
Set isObservableStoreEnabled explicitly
tinder-garricnahapetian Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Sources/NodesGenerator/Config.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ public struct Config: Codable, Equatable {
public var isTestTemplatesGenerationEnabled: Bool
public var isPeripheryCommentEnabled: Bool

public var storePrefix: String { isObservableStoreEnabled ? "Observable" : "" }
public var isNimbleEnabled: Bool { baseTestImports.contains("Nimble") }

public init(
Expand Down
8 changes: 8 additions & 0 deletions Tests/NodesGeneratorTests/ConfigTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,14 @@ final class ConfigTests: XCTestCase, TestFactories {
}
}

func testStorePrefix() {
var config: Config = .init()
config.isObservableStoreEnabled = false
expect(config.storePrefix.isEmpty) == true
config.isObservableStoreEnabled = true
expect(config.storePrefix) == "Observable"
}

func testIsNimbleEnabled() {
var config: Config = .init()
config.baseTestImports = ["Nimble"]
Expand Down