Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NodesTesting import to test stencils #835

Merged
merged 6 commits into from
Sep 23, 2024
Merged

Add NodesTesting import to test stencils #835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ffaf2c2
Check isViewInjected in imports(with:including:)
tinder-garricnahapetian Sep 11, 2024
90767b3
Remove local property
tinder-garricnahapetian Sep 19, 2024
f338f9f
Move test as not needed
tinder-garricnahapetian Sep 19, 2024
996e2a5
Fix imports for SwiftUI
tinder-garricnahapetian Sep 19, 2024
13b5557
Improve formatting
tinder-garricnahapetian Sep 20, 2024
86e279a
Remove as not needed
tinder-garricnahapetian Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Sources/NodesGenerator/StencilTemplate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,7 @@ public enum StencilTemplate: CustomStringConvertible, Equatable, Sendable {
.union(config.reactiveImports)
case .contextTests:
config.baseTestImports
.union(uiFramework == nil ? [] : ["NodesTesting"])
case .flow:
config.baseImports
.union(["Nodes"])
Expand Down Expand Up @@ -277,7 +278,7 @@ public enum StencilTemplate: CustomStringConvertible, Equatable, Sendable {
.union(uiFramework.flatMap { [$0.import] } ?? [])
case .viewControllerTests:
uiFramework == nil ? [] : config.baseTestImports
.union(config.reactiveImports)
.union(uiFramework?.kind.isHostingSwiftUI == true ? ["NodesTesting"] : config.reactiveImports)
case .viewState:
uiFramework == nil ? [] : config.baseImports
.union(["Nodes"])
Expand Down
5 changes: 3 additions & 2 deletions Tests/NodesGeneratorTests/StencilTemplateTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,8 @@ final class StencilTemplateTests: XCTestCase, TestFactories {
]
case .contextTests:
expect(imports) == [
"<baseTestImport>"
"<baseTestImport>",
"NodesTesting"
]
case .flow:
expect(imports) == [
Expand Down Expand Up @@ -345,7 +346,7 @@ final class StencilTemplateTests: XCTestCase, TestFactories {
case .viewControllerTests:
expect(imports) == [
"<baseTestImport>",
"<reactiveImport>"
uiFramework.kind.isHostingSwiftUI ? "NodesTesting" : "<reactiveImport>"
]
case .viewState:
expect(imports) == [
Expand Down
1 change: 1 addition & 0 deletions ..._/XcodeTemplateGeneratorTests/testGenerateWithIdentifier.Contents-AppKit-ContextTests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#warning("Manually move this test file to the corresponding test target then delete this warning.")

import Nimble
import NodesTesting
import XCTest

final class ___VARIABLE_productName___ContextTests: XCTestCase {
Expand Down
1 change: 1 addition & 0 deletions ...atorTests/testGenerateWithIdentifier.Contents-AppKitCreatedForPluginList-ContextTests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#warning("Manually move this test file to the corresponding test target then delete this warning.")

import Nimble
import NodesTesting
import XCTest

final class ___VARIABLE_productName___ContextTests: XCTestCase {
Expand Down
1 change: 1 addition & 0 deletions ...TemplateGeneratorTests/testGenerateWithIdentifier.Contents-AppKitSwiftUI-ContextTests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#warning("Manually move this test file to the corresponding test target then delete this warning.")

import Nimble
import NodesTesting
import XCTest

final class ___VARIABLE_productName___ContextTests: XCTestCase {
Expand Down
2 changes: 1 addition & 1 deletion ...eGeneratorTests/testGenerateWithIdentifier.Contents-AppKitSwiftUI-ViewControllerTests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

#warning("Manually move this test file to the corresponding test target then delete this warning.")

import Combine
import Nimble
import NodesTesting
import XCTest

final class ___VARIABLE_productName___ViewControllerTests: XCTestCase {
Expand Down
1 change: 1 addition & 0 deletions ...ts/testGenerateWithIdentifier.Contents-AppKitSwiftUICreatedForPluginList-ContextTests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#warning("Manually move this test file to the corresponding test target then delete this warning.")

import Nimble
import NodesTesting
import XCTest

final class ___VARIABLE_productName___ContextTests: XCTestCase {
Expand Down
2 changes: 1 addition & 1 deletion ...GenerateWithIdentifier.Contents-AppKitSwiftUICreatedForPluginList-ViewControllerTests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

#warning("Manually move this test file to the corresponding test target then delete this warning.")

import Combine
import Nimble
import NodesTesting
import XCTest

final class ___VARIABLE_productName___ViewControllerTests: XCTestCase {
Expand Down
1 change: 1 addition & 0 deletions ..._/XcodeTemplateGeneratorTests/testGenerateWithIdentifier.Contents-Custom-ContextTests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#warning("Manually move this test file to the corresponding test target then delete this warning.")

import Nimble
import NodesTesting
import XCTest

final class ___VARIABLE_productName___ContextTests: XCTestCase {
Expand Down
1 change: 1 addition & 0 deletions ...atorTests/testGenerateWithIdentifier.Contents-CustomCreatedForPluginList-ContextTests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#warning("Manually move this test file to the corresponding test target then delete this warning.")

import Nimble
import NodesTesting
import XCTest

final class ___VARIABLE_productName___ContextTests: XCTestCase {
Expand Down
1 change: 1 addition & 0 deletions ...__/XcodeTemplateGeneratorTests/testGenerateWithIdentifier.Contents-UIKit-ContextTests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#warning("Manually move this test file to the corresponding test target then delete this warning.")

import Nimble
import NodesTesting
import XCTest

final class ___VARIABLE_productName___ContextTests: XCTestCase {
Expand Down
1 change: 1 addition & 0 deletions ...ratorTests/testGenerateWithIdentifier.Contents-UIKitCreatedForPluginList-ContextTests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#warning("Manually move this test file to the corresponding test target then delete this warning.")

import Nimble
import NodesTesting
import XCTest

final class ___VARIABLE_productName___ContextTests: XCTestCase {
Expand Down
1 change: 1 addition & 0 deletions ...eTemplateGeneratorTests/testGenerateWithIdentifier.Contents-UIKitSwiftUI-ContextTests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#warning("Manually move this test file to the corresponding test target then delete this warning.")

import Nimble
import NodesTesting
import XCTest

final class ___VARIABLE_productName___ContextTests: XCTestCase {
Expand Down
2 changes: 1 addition & 1 deletion ...teGeneratorTests/testGenerateWithIdentifier.Contents-UIKitSwiftUI-ViewControllerTests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

#warning("Manually move this test file to the corresponding test target then delete this warning.")

import Combine
import Nimble
import NodesTesting
import XCTest

final class ___VARIABLE_productName___ViewControllerTests: XCTestCase {
Expand Down
1 change: 1 addition & 0 deletions ...sts/testGenerateWithIdentifier.Contents-UIKitSwiftUICreatedForPluginList-ContextTests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#warning("Manually move this test file to the corresponding test target then delete this warning.")

import Nimble
import NodesTesting
import XCTest

final class ___VARIABLE_productName___ContextTests: XCTestCase {
Expand Down
2 changes: 1 addition & 1 deletion ...tGenerateWithIdentifier.Contents-UIKitSwiftUICreatedForPluginList-ViewControllerTests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

#warning("Manually move this test file to the corresponding test target then delete this warning.")

import Combine
import Nimble
import NodesTesting
import XCTest

final class ___VARIABLE_productName___ViewControllerTests: XCTestCase {
Expand Down
1 change: 1 addition & 0 deletions ...pshots__/XcodeTemplateGeneratorTests/testGenerateWithURL.Contents-AppKit-ContextTests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#warning("Manually move this test file to the corresponding test target then delete this warning.")

import Nimble
import NodesTesting
import XCTest

final class ___VARIABLE_productName___ContextTests: XCTestCase {
Expand Down
1 change: 1 addition & 0 deletions ...teGeneratorTests/testGenerateWithURL.Contents-AppKitCreatedForPluginList-ContextTests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#warning("Manually move this test file to the corresponding test target then delete this warning.")

import Nimble
import NodesTesting
import XCTest

final class ___VARIABLE_productName___ContextTests: XCTestCase {
Expand Down
1 change: 1 addition & 0 deletions ..._/XcodeTemplateGeneratorTests/testGenerateWithURL.Contents-AppKitSwiftUI-ContextTests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#warning("Manually move this test file to the corresponding test target then delete this warning.")

import Nimble
import NodesTesting
import XCTest

final class ___VARIABLE_productName___ContextTests: XCTestCase {
Expand Down
2 changes: 1 addition & 1 deletion ...TemplateGeneratorTests/testGenerateWithURL.Contents-AppKitSwiftUI-ViewControllerTests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

#warning("Manually move this test file to the corresponding test target then delete this warning.")

import Combine
import Nimble
import NodesTesting
import XCTest

final class ___VARIABLE_productName___ViewControllerTests: XCTestCase {
Expand Down
1 change: 1 addition & 0 deletions ...atorTests/testGenerateWithURL.Contents-AppKitSwiftUICreatedForPluginList-ContextTests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#warning("Manually move this test file to the corresponding test target then delete this warning.")

import Nimble
import NodesTesting
import XCTest

final class ___VARIABLE_productName___ContextTests: XCTestCase {
Expand Down
2 changes: 1 addition & 1 deletion ...ts/testGenerateWithURL.Contents-AppKitSwiftUICreatedForPluginList-ViewControllerTests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

#warning("Manually move this test file to the corresponding test target then delete this warning.")

import Combine
import Nimble
import NodesTesting
import XCTest

final class ___VARIABLE_productName___ViewControllerTests: XCTestCase {
Expand Down
1 change: 1 addition & 0 deletions ...pshots__/XcodeTemplateGeneratorTests/testGenerateWithURL.Contents-Custom-ContextTests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#warning("Manually move this test file to the corresponding test target then delete this warning.")

import Nimble
import NodesTesting
import XCTest

final class ___VARIABLE_productName___ContextTests: XCTestCase {
Expand Down
1 change: 1 addition & 0 deletions ...teGeneratorTests/testGenerateWithURL.Contents-CustomCreatedForPluginList-ContextTests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#warning("Manually move this test file to the corresponding test target then delete this warning.")

import Nimble
import NodesTesting
import XCTest

final class ___VARIABLE_productName___ContextTests: XCTestCase {
Expand Down
1 change: 1 addition & 0 deletions ...apshots__/XcodeTemplateGeneratorTests/testGenerateWithURL.Contents-UIKit-ContextTests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#warning("Manually move this test file to the corresponding test target then delete this warning.")

import Nimble
import NodesTesting
import XCTest

final class ___VARIABLE_productName___ContextTests: XCTestCase {
Expand Down
1 change: 1 addition & 0 deletions ...ateGeneratorTests/testGenerateWithURL.Contents-UIKitCreatedForPluginList-ContextTests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#warning("Manually move this test file to the corresponding test target then delete this warning.")

import Nimble
import NodesTesting
import XCTest

final class ___VARIABLE_productName___ContextTests: XCTestCase {
Expand Down
1 change: 1 addition & 0 deletions ...__/XcodeTemplateGeneratorTests/testGenerateWithURL.Contents-UIKitSwiftUI-ContextTests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#warning("Manually move this test file to the corresponding test target then delete this warning.")

import Nimble
import NodesTesting
import XCTest

final class ___VARIABLE_productName___ContextTests: XCTestCase {
Expand Down
2 changes: 1 addition & 1 deletion ...eTemplateGeneratorTests/testGenerateWithURL.Contents-UIKitSwiftUI-ViewControllerTests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

#warning("Manually move this test file to the corresponding test target then delete this warning.")

import Combine
import Nimble
import NodesTesting
import XCTest

final class ___VARIABLE_productName___ViewControllerTests: XCTestCase {
Expand Down
1 change: 1 addition & 0 deletions ...ratorTests/testGenerateWithURL.Contents-UIKitSwiftUICreatedForPluginList-ContextTests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#warning("Manually move this test file to the corresponding test target then delete this warning.")

import Nimble
import NodesTesting
import XCTest

final class ___VARIABLE_productName___ContextTests: XCTestCase {
Expand Down
2 changes: 1 addition & 1 deletion ...sts/testGenerateWithURL.Contents-UIKitSwiftUICreatedForPluginList-ViewControllerTests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

#warning("Manually move this test file to the corresponding test target then delete this warning.")

import Combine
import Nimble
import NodesTesting
import XCTest

final class ___VARIABLE_productName___ViewControllerTests: XCTestCase {
Expand Down
5 changes: 3 additions & 2 deletions ...PermutationTests/testNodeXcodeTemplatePermutation.AppKit-SwiftUI-CreatedForPluginList.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,9 @@
- "<baseImport>"
- "<reactiveImport>"
- "Nodes"
▿ contextTestsImports: 1 element
▿ contextTestsImports: 2 elements
- "<baseTestImport>"
- "NodesTesting"
▿ dependencies: 1 element
▿ 2 key/value pairs
▿ (2 elements)
Expand Down Expand Up @@ -86,7 +87,7 @@
- viewControllerSuperParameters: ""
▿ viewControllerTestsImports: 2 elements
- "<baseTestImport>"
- "<reactiveImport>"
- "NodesTesting"
- viewControllerType: "NSHostingController"
- viewControllerUpdateComment: "<viewControllerUpdateComment>"
- viewStateEmptyFactory: "<viewStateEmptyFactory>"
Expand Down
5 changes: 3 additions & 2 deletions ...shots__/XcodeTemplatePermutationTests/testNodeXcodeTemplatePermutation.AppKit-SwiftUI.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,9 @@
- "<baseImport>"
- "<reactiveImport>"
- "Nodes"
▿ contextTestsImports: 1 element
▿ contextTestsImports: 2 elements
- "<baseTestImport>"
- "NodesTesting"
▿ dependencies: 1 element
▿ 2 key/value pairs
▿ (2 elements)
Expand Down Expand Up @@ -86,7 +87,7 @@
- viewControllerSuperParameters: ""
▿ viewControllerTestsImports: 2 elements
- "<baseTestImport>"
- "<reactiveImport>"
- "NodesTesting"
- viewControllerType: "NSHostingController"
- viewControllerUpdateComment: "<viewControllerUpdateComment>"
- viewStateEmptyFactory: "<viewStateEmptyFactory>"
Expand Down
3 changes: 2 additions & 1 deletion ...s/__Snapshots__/XcodeTemplatePermutationTests/testNodeXcodeTemplatePermutation.AppKit.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,9 @@
- "<baseImport>"
- "<reactiveImport>"
- "Nodes"
▿ contextTestsImports: 1 element
▿ contextTestsImports: 2 elements
- "<baseTestImport>"
- "NodesTesting"
▿ dependencies: 1 element
▿ 2 key/value pairs
▿ (2 elements)
Expand Down
3 changes: 2 additions & 1 deletion ...eTemplatePermutationTests/testNodeXcodeTemplatePermutation.AppKitCreatedForPluginList.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,9 @@
- "<baseImport>"
- "<reactiveImport>"
- "Nodes"
▿ contextTestsImports: 1 element
▿ contextTestsImports: 2 elements
- "<baseTestImport>"
- "NodesTesting"
▿ dependencies: 1 element
▿ 2 key/value pairs
▿ (2 elements)
Expand Down
3 changes: 2 additions & 1 deletion ...s/__Snapshots__/XcodeTemplatePermutationTests/testNodeXcodeTemplatePermutation.Custom.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,9 @@
- "<baseImport>"
- "<reactiveImport>"
- "Nodes"
▿ contextTestsImports: 1 element
▿ contextTestsImports: 2 elements
- "<baseTestImport>"
- "NodesTesting"
▿ dependencies: 1 element
▿ 2 key/value pairs
▿ (2 elements)
Expand Down
3 changes: 2 additions & 1 deletion ...eTemplatePermutationTests/testNodeXcodeTemplatePermutation.CustomCreatedForPluginList.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,9 @@
- "<baseImport>"
- "<reactiveImport>"
- "Nodes"
▿ contextTestsImports: 1 element
▿ contextTestsImports: 2 elements
- "<baseTestImport>"
- "NodesTesting"
▿ dependencies: 1 element
▿ 2 key/value pairs
▿ (2 elements)
Expand Down
5 changes: 3 additions & 2 deletions ...ePermutationTests/testNodeXcodeTemplatePermutation.UIKit-SwiftUI-CreatedForPluginList.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,9 @@
- "<baseImport>"
- "<reactiveImport>"
- "Nodes"
▿ contextTestsImports: 1 element
▿ contextTestsImports: 2 elements
- "<baseTestImport>"
- "NodesTesting"
▿ dependencies: 1 element
▿ 2 key/value pairs
▿ (2 elements)
Expand Down Expand Up @@ -86,7 +87,7 @@
- viewControllerSuperParameters: ""
▿ viewControllerTestsImports: 2 elements
- "<baseTestImport>"
- "<reactiveImport>"
- "NodesTesting"
- viewControllerType: "UIHostingController"
- viewControllerUpdateComment: "<viewControllerUpdateComment>"
- viewStateEmptyFactory: "<viewStateEmptyFactory>"
Expand Down
5 changes: 3 additions & 2 deletions ...pshots__/XcodeTemplatePermutationTests/testNodeXcodeTemplatePermutation.UIKit-SwiftUI.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,9 @@
- "<baseImport>"
- "<reactiveImport>"
- "Nodes"
▿ contextTestsImports: 1 element
▿ contextTestsImports: 2 elements
- "<baseTestImport>"
- "NodesTesting"
▿ dependencies: 1 element
▿ 2 key/value pairs
▿ (2 elements)
Expand Down Expand Up @@ -86,7 +87,7 @@
- viewControllerSuperParameters: ""
▿ viewControllerTestsImports: 2 elements
- "<baseTestImport>"
- "<reactiveImport>"
- "NodesTesting"
- viewControllerType: "UIHostingController"
- viewControllerUpdateComment: "<viewControllerUpdateComment>"
- viewStateEmptyFactory: "<viewStateEmptyFactory>"
Expand Down
Loading