-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add async stdio files #154
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,22 @@ | ||
"""Utilities for asyncio-friendly file handling.""" | ||
from .threadpool import open | ||
from .threadpool import ( | ||
open, | ||
stdin, | ||
stdout, | ||
stderr, | ||
stdin_bytes, | ||
stdout_bytes, | ||
stderr_bytes, | ||
) | ||
from . import tempfile | ||
|
||
__all__ = ["open", "tempfile"] | ||
__all__ = [ | ||
"open", | ||
"tempfile", | ||
"stdin", | ||
"stdout", | ||
"stderr", | ||
"stdin_bytes", | ||
"stdout_bytes", | ||
"stderr_bytes", | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
import sys | ||
import pytest | ||
from aiofiles import stdout, stderr, stdout_bytes, stderr_bytes | ||
|
||
|
||
@pytest.mark.asyncio | ||
async def test_stdio(capsys): | ||
await stdout.write("hello") | ||
await stderr.write("world") | ||
out, err = capsys.readouterr() | ||
assert out == "hello" | ||
assert err == "world" | ||
|
||
|
||
@pytest.mark.asyncio | ||
async def test_stdio_bytes(capsysbinary): | ||
await stdout_bytes.write(b"hello") | ||
await stderr_bytes.write(b"world") | ||
out, err = capsysbinary.readouterr() | ||
assert out == b"hello" | ||
assert err == b"world" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where do the TypeErrors come from btw?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sys.stdin
may have been patched to be an unusable base type prior to importing aiofiles. This happens specifically when using pytest. I figured I would add it to the rest of the stdio files just be safe.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, alright. Do we want to document this for people somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo the best documentation would be replacing the
stdin = None
with a custom class which raises a descriptive error when you try to use any of its methods. I was hoping I could convince you to do that 😅lmk if you would like to do that or just add a note to the readme/docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind, just thought of a much better solution. One sec.