Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace deprecated wildcard with matcher and update readme with new YAML configuration format #7

Merged
merged 2 commits into from
Sep 23, 2019
Merged

replace deprecated wildcard with matcher and update readme with new YAML configuration format #7

merged 2 commits into from
Sep 23, 2019

Conversation

amacado
Copy link
Contributor

@amacado amacado commented Sep 5, 2019

I managed to get this action working in the new YAML format. Through debugging I found some issues in the wildcard dependency therefore I decided to replace it with the official recommended replacement: matcher.

Changelog

Work on this project is largely inactive, now so I'd recommend checking out the wonderful matcher package as a solid alternative.
https://www.npmjs.com/package/wildcard

Hope you (and others) find it useful. If you (@TimonVS) like we can talk about sharing this little project. I would be willing to volunteer as a maintainer since I find this useful and will be using it in some projects.

@gonzalosr
Copy link

Thank you @amacado for stepping in! Count on me if you get to maintain the project and need some more help

@TimonVS It would be great to have this merged before the deprecation of HCL Github Actions, your plugin is so good :)

@amacado
Copy link
Contributor Author

amacado commented Sep 19, 2019

Thank you @gonzalosr, hope to get this merged soon. @TimonVS seems to be inactive in this project and I would be glad to maintain this helpful project. I will try to contact him via other communication ways to see if we have a chance to continue this.

@TimonVS
Copy link
Owner

TimonVS commented Sep 23, 2019

Hey @amacado and others, first of all thanks so much for the PR. I meant to do this myself but about a month ago I got very sick, I'm currently still hospitalized but I do have my laptop here now. I'm currently checking the PR, so far it looks great!

Copy link
Owner

@TimonVS TimonVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks a lot for your contribution :)

@TimonVS TimonVS merged commit 8ef332f into TimonVS:master Sep 23, 2019
@amacado amacado deleted the feature/replace-wildcard-dependency branch September 23, 2019 08:35
@TimonVS
Copy link
Owner

TimonVS commented Sep 25, 2019

@all-contributors please add @amacado for code, docs, bug

@allcontributors
Copy link
Contributor

@TimonVS

I've put up a pull request to add @amacado! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't get it to work in new yml format
4 participants