Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer byteorder in place of bincode #607

Merged

Conversation

frankmcsherry
Copy link
Member

Some framing parts of Message<C, T> use bincode to encode u64 data, though byteorder is just as good and may have better alignment properties (it's unclear if bincode ensures alignment, or uses clever varint encoding). This moves us in a direction where there can be more certainty about the shape of serialized data, that would make zero-copy deserialization, which relies on alignment of bytes to be efficient, more likely to work out well.

@frankmcsherry frankmcsherry merged commit 7a1ece7 into TimelyDataflow:master Dec 5, 2024
7 checks passed
@github-actions github-actions bot mentioned this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant