Prefer byteorder
in place of bincode
#607
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some framing parts of
Message<C, T>
usebincode
to encodeu64
data, thoughbyteorder
is just as good and may have better alignment properties (it's unclear ifbincode
ensures alignment, or uses clever varint encoding). This moves us in a direction where there can be more certainty about the shape of serialized data, that would make zero-copy deserialization, which relies on alignment of bytes to be efficient, more likely to work out well.