Back MutableAntichain by ChangeBatch
#505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benesch
approved these changes
Feb 20, 2023
6b67c87 to
ce1b7c1
Compare
teskje
added a commit
to teskje/materialize
that referenced
this pull request
Feb 21, 2023
This is to pick up TimelyDataflow/timely-dataflow#505, which fixes a memory leak in environmentd.
4 tasks
teskje
added a commit
to MaterializeInc/materialize
that referenced
this pull request
Feb 21, 2023
This is to pick up TimelyDataflow/timely-dataflow#505, which fixes a memory leak in environmentd.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
Vec<(T, i64)>fromMutableAntichainand replaces it with aChangeBatch<T>. There is a regression here in that several "unsafe" methods involving dirty bits are removed. Their justification was around progress tracking, and that justification no longer exists. This removes several ways in which one could write incorrect code (by dirtying things up and then reading data without first cleaning). These are now prevented.Some potential for performance regressions in that certain loops are not exited as early as they are elsewhere, and the eager compaction work may not be helpful in all cases.
cc: @teskje
fixes #504