Add cease to output handles #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In certain situations, a handle survives longer than we would like to wait for a flush to happen. In this cases, an explicit call to cease can help to indicate to the rest of the system that no more data follows immediately, which is equivalent to dropping the handle. Specifically, in async code the handle can be long-lived and survive await points, which makes it more important to signal momentary completion to the system. Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
4 tasks
frankmcsherry
approved these changes
Jan 20, 2023
There was a problem hiding this comment.
Approving, though as discussed it's awkward that we can't really say what this function does other than flush some buffers. It does not seem to require (either idiomatically, or through the signature) that you actually "cease" so much as force a flush of the buffers.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain situations, a handle survives longer than we would like to wait for a flush to happen. In this cases, an explicit call to cease can help to indicate to the rest of the system that no more data follows immediately, which is equivalent to dropping the handle.
Specifically, in async code the handle can be long-lived and survive await points, which makes it more important to signal momentary completion to the system.
Signed-off-by: Moritz Hoffmann antiguru@gmail.com