Avoid spinning when workers have no dataflows #463
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meant to address the same issue as #461, and up for discussion.
The intent here is that calling
worker.step_or_park(duration)
should not ignore the argument whenworker.dataflows
is empty. It chose to, because it our shutdown code we end up in a loop that won't break out there are no dataflows (and nothing to wake us). Some head scratching later, I deemed this to be a bug in the shutdown code: we shouldn't enter the loop if there are no dataflows, and if there are dataflows then we will exit it (as reaching zero dataflows is the test to break out of the loop).Said differently, the code should probably have been:
and .. we could still do that. This PR does
a similar change that is not quite as clearexactly that.