Allow exchange operator to take FnMut #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems good; thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the underlying
channels::pact::Exchangealready can store anFnMutas the hash function, it seems like the exchange operator should be able to support taking one as well. I'm still getting my bearings with Timely and Rust, so if there's a reason for the mismatch, I'd love to learn about why.FWIW, my use case: for reasons unrelated to Timely, I have a limit on how many workers can gather input from the previous system, so I'd like to round-robin exchange right away with a counter, so additional workers have things to chew on in the early part of the dataflow. I know I could hash the input or generate random numbers currently, but this seemed like it could be supported as well.
Thanks!