More debug implementations #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankmcsherry
approved these changes
Jun 2, 2021
There was a problem hiding this comment.
These largely look great. I flagged a few formatting nits because we chatted about them. None of them are big deals, but each of them are "this will be harder for you to read now" changes which .. certainly aren't the end of the world.
I'm going to take a peek at a rustfmt.toml and see if I can put one together that I can live with, and then I won't end up saying things like this in the future. :D
|
I think I fixed everything, thanks! |
|
Thanks very much! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a bunch of debug implementations and some minor clippy lints