Fix ability to eliminate getopts dep #385
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the use of [features] getopts = ["timely_communication/getopts"] it appears that it was intended for timely_communication's "getopts" feature to be only conditionally enabled. However "getopts" is a default feature of timely_communication.
In order for a crate that depends on
timely
to be able to avoid thegetopts
dependency when it has no need fortimely::execute_from_args
, timely must not unconditionally enable timely_communication's default features.PR tested with a crate that depends on timely with default-features=false, using
cargo check
to confirm it's able to build andcargo tree
to confirm the getopts transitive dependency is now correctly eliminated.