Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notificator notification count is always 1 #395

Closed
antiguru opened this issue Jun 12, 2021 · 0 comments · Fixed by #396 or #594
Closed

Notificator notification count is always 1 #395

antiguru opened this issue Jun 12, 2021 · 0 comments · Fixed by #396 or #594

Comments

@antiguru
Copy link
Member

The notificator's for_each function claims to invoke the passed function with the parameters cap, count, notificator, where count represents how many times notify_at has been called for the capability. In reality, it always returns 1.
antiguru added a commit to antiguru/timely-dataflow that referenced this issue Jun 12, 2021
@antiguru
Fix TimelyDataflow#395: Add next_count returning the notification count
bd572b5 
Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
@antiguru antiguru mentioned this issue Jun 12, 2021
Merged
antiguru added a commit to antiguru/timely-dataflow that referenced this issue Jun 12, 2021
@antiguru
Fix TimelyDataflow#395: Add next_count returning the notification count
89b5e56 
Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
frankmcsherry pushed a commit that referenced this issue Jun 30, 2021
@antiguru
Fix #395: Add next_count returning the notification count (#396)
8ba3286 
* Fix #395: Add next_count returning the notification count

Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>

* Remeber the original count in `OrderReversed`

Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
@github-actions github-actions bot mentioned this issue Oct 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@antiguru