Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More DatePicker control #46

Closed
wants to merge 4 commits into from
Closed

More DatePicker control #46

wants to merge 4 commits into from

Conversation

detouch
Copy link

@detouch detouch commented Jun 21, 2012

Hi Tim

I have added the following properties to the ActionSheetDatePicker class:

  • minimumDate
  • maximumDate
  • minuteInterval

The example app does also make use of these properties.
Feel free to pull in these improvement.

Cheers
Daniel

PS: This was also requested as a feature in your issue #38.

@skywinder
Copy link
Collaborator

Hi. Thanks for contribution.
Unfortunately I can't merge your request due these reasons:
0) Your pull request is outdated. (even it don't support ARC)

  1. minimumDate and maximumDate already implemented from another pull request. And I orJack-s will add minuteInterval soon.
  2. customDoneButton is a good idea, but it should be added in separate pull request.

@skywinder skywinder closed this Jul 10, 2014
@ma2kubo
Copy link

ma2kubo commented Jul 10, 2014

Evernote was unable to submit your note for the following reason:

The emailed note was received, but Evernote did not understand the email address. It may have been mistyped, or the user may not exist. Please check to make sure the address was properly entered.

Original message information:
From: Petr Korolev <notifications@github.com>
Delivered To: deviceone.c1297@m.evernote.com
All recipients: TimCinel/ActionSheetPicker <ActionSheetPicker@noreply.github.com>
Subject: Re: [ActionSheetPicker] More DatePicker control (#46)

To prevent excessive emails, you may not receive another error reply for the next 360 minutes.

  • The Evernote team

@skywinder
Copy link
Collaborator

Also, there is a nice pull request with more flexible customisation of buttons: #87

jum pushed a commit to jum/ActionSheetPicker that referenced this pull request Sep 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants