-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style the framed editor #3596
style the framed editor #3596
Conversation
this makes the framed editor look a bit less ugly 😎
box-shadow on the iframe would look really good, I just don't know how to set it ... should it be copied from the tiddler frame to know if the theme sets shadows? |
ah, nevermind, I found the solution |
this removes also the bottom right resize handle which looks bad and has no real value |
Thanks @BurningTreeC |
didn't expect this getting merged 😁 - thank you! |
Hi @BurningTreeC my fault, I did not realise that this was a new change, I just assumed that it was another of the recent torrent of tweaks. I think the moral of the story is that if you're going to suggest a change in the core look and feel then it's important to explain what you're doing and why, and ideally show before and after pictures so that as many people as possible can participate. |
Hi @BurningTreeC I'm having trouble reverting this commit because of merge conflicts. Would you be able to prepare a new PR that restores the editor textarea appearance to where we were last week? Many thanks. |
yeah, this was a bit premature of myself - I take the responsability |
* style the framed editor this makes the framed editor look a bit less ugly 😎 * Update framed.js * Update base.tid * Update base.tid
this makes the framed editor look a bit less ugly 😎