Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style the framed editor #3596

Merged
merged 4 commits into from
Dec 1, 2018
Merged

style the framed editor #3596

merged 4 commits into from
Dec 1, 2018

Conversation

BurningTreeC
Copy link
Contributor

this makes the framed editor look a bit less ugly 😎

this makes the framed editor look a bit less ugly 😎
@BurningTreeC
Copy link
Contributor Author

box-shadow on the iframe would look really good, I just don't know how to set it ... should it be copied from the tiddler frame to know if the theme sets shadows?

@BurningTreeC
Copy link
Contributor Author

ah, nevermind, I found the solution

@BurningTreeC
Copy link
Contributor Author

this removes also the bottom right resize handle which looks bad and has no real value

@Jermolene
Copy link
Member

Thanks @BurningTreeC

@Jermolene Jermolene merged commit 6e59d25 into TiddlyWiki:master Dec 1, 2018
@BurningTreeC
Copy link
Contributor Author

didn't expect this getting merged 😁 - thank you!

@BurningTreeC BurningTreeC deleted the patch-62 branch December 1, 2018 14:23
@Jermolene
Copy link
Member

Hi @BurningTreeC my fault, I did not realise that this was a new change, I just assumed that it was another of the recent torrent of tweaks.

I think the moral of the story is that if you're going to suggest a change in the core look and feel then it's important to explain what you're doing and why, and ideally show before and after pictures so that as many people as possible can participate.

@Jermolene
Copy link
Member

Hi @BurningTreeC I'm having trouble reverting this commit because of merge conflicts. Would you be able to prepare a new PR that restores the editor textarea appearance to where we were last week? Many thanks.

@Jermolene Jermolene mentioned this pull request Dec 3, 2018
@BurningTreeC
Copy link
Contributor Author

I think the moral of the story is that if you're going to suggest a change in the core look and feel then it's important to explain what you're doing and why, and ideally show before and after pictures so that as many people as possible can participate.

yeah, this was a bit premature of myself - I take the responsability

jho1965us pushed a commit to jho1965us/TiddlyWiki5 that referenced this pull request Apr 3, 2019
* style the framed editor

this makes the framed editor look a bit less ugly 😎

* Update framed.js

* Update base.tid

* Update base.tid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants