HTML Nexus response handling fixed

[aresok]

See #7 - this request provides fix for the issue.
Additionally, it reduces the size of created artifact (Jar) from ~9 to ~2MB.

[arvindsv]

Hi @aresok. Thanks for this! I have the "authority" to accept this pull request, but since I haven't written this or directly worked with it, I wouldn't be able to add much in the way of feedback. However, I was wondering whether you'd be interested in owning this repository.

The original owner of this plugin seems to have abandoned it, but since you have submitted what looks like a very well thought-out pull request, I was wondering whether you'd like to own it. I am willing to do the legwork of finding the right people to convince about this, transfer the repo from here and change the ownership details mentioned here. You'd also (obviously) get direct access to the repo.

Let me know if you're interested. Well, let me know even if you aren't. :)

Thanks,
Aravind

PS: Even if you agree, I'll still have to ask around whether it's ok. I suspect it'll be alright. But, I thought I'd ask you first.

[aresok]

HI @arvindsw. I didn't expect such proposal! Thank you for that. And yes, I agree, I can take the ownership. Just let me know when I will be able to start! :)

regards,
Arek

[arvindsv]

Oops, forgot to respond to you, @aresok. Cool! I saw your response, and started conversations about this. Looks like people are on board with this. I'm working on the rest of the activities around this. Expect this to happen in a few days.

[jefftrimm]

@aresok Nice job on this patch... I built and deployed locally and it is now picking up the latest artifact. Before the plugin simply was not working at all, so this is a huge fix. I'm doing a POC using Go 14.3, so it works in that version.

[jefftrimm]

@aresok -- Hey when I look at the console output of my tasks in my jobs, which includes a dump of all of the environment variables being set, I don't see the GO_PACKAGE___LOCATION environment variable being set? It's in the documentation, and from a deployment-script standpoint, that's one of the key values you'll be typically feeding a deploy script. Is that being missed somehow in this patch?

[aresok]

Hi @jefftrimm,
I just checked it locally - and all env variables are in place, and artifact pointed in GO_PACKAGE__LOCATION is available.
The patchset does not modify exported variables; however, it is possible, that creation of some variables fails in specific circumstances - can you look in logs for that?
Or maybe you can describe / provide your test environment?
I'm testing with Go 14.3.0(1186-65818fec82f654).
Extract from log (values dotted out), at the end there is a GO_PACKAGE_SWT_FORGOPACKAGE_LOCATION env variable (it contains valid artifact):

[go] setting environment variable 'GO_ENVIRONMENT_NAME' to value 'XXX'
[go] setting environment variable 'GO_SERVER_URL' to value 'XXX'
[go] setting environment variable 'GO_TRIGGER_USER' to value 'XXX'
[go] setting environment variable 'GO_PIPELINE_NAME' to value 'nexuser'
[go] setting environment variable 'GO_PIPELINE_COUNTER' to value '4'
[go] setting environment variable 'GO_PIPELINE_LABEL' to value '4'
[go] setting environment variable 'GO_STAGE_NAME' to value 'defaultStage'
[go] setting environment variable 'GO_STAGE_COUNTER' to value '1'
[go] setting environment variable 'GO_JOB_NAME' to value 'defaultJob'
[go] setting environment variable 'GO_PACKAGE_SWT_FORGOPACKAGE_LABEL' to value 'XXX'
[go] setting environment variable 'GO_REPO_SWT_FORGOPACKAGE_REPO_URL' to value 'XXX'
[go] setting environment variable 'GO_PACKAGE_SWT_FORGOPACKAGE_GROUP_ID' to value 'XXX'
[go] setting environment variable 'GO_PACKAGE_SWT_FORGOPACKAGE_ARTIFACT_ID' to value 'XXX'
[go] setting environment variable 'GO_PACKAGE_SWT_FORGOPACKAGE_PACKAGING' to value 'war'
[go] setting environment variable 'GO_PACKAGE_SWT_FORGOPACKAGE_VERSION' to value '1.0.61'
[go] setting environment variable 'GO_PACKAGE_SWT_FORGOPACKAGE_LOCATION' to value 'XXX'

[aresok]

Hi,
any progress with this one?
We are using the plugin in some our internal pipelines, and it works (GO_PACKAGE__LOCATION env variable is fine).

[arvindsv]

Hi @aresok. I'm closing this PR. I've removed all the files in this repo, and I've put in a redirection message to your repo. I've submitted a PR for the plugins page on go.cd, which changes the owner to you. That should get accepted soon.

You might want to look at the issues on this go-maven-poller project, and open corresponding issues, if they make sense. You can link them back to the issues on this repo. It is not going to get deleted (at least by me).

Let me know if I've missed anything.

Cheers,
Aravind

[arvindsv]

The PR has been accepted by @mdaliejaz. You're the owner now! Congratulations! Feel free to ask for help, any time.

[jefftrimm]

The new github site doesn't seem to have any ability to submit issues? https://github.com/aresok/go-maven-poller https://github.com/aresok/go-maven-poller

Also, it doesn't look like the latest release includes all of the latest fixes? https://github.com/aresok/go-maven-poller/releases https://github.com/aresok/go-maven-poller/releases

-Jeff

On Jan 2, 2015, at 7:58 PM, Aravind SV notifications@github.com wrote:

The PR has been accepted by @mdaliejaz https://github.com/mdaliejaz. You're the owner now! Congratulations! Feel free to ask for help, any time.

—
Reply to this email directly or view it on GitHub #10 (comment).

[arvindsv]

I checked with one of my forks, and issues can be enabled in the settings of the repository. @aresok needs to do that. @aresok?

[aresok]

Hi,
currently I'm involved in other things - I will look at the poller in about
a week; sorry for that, regards!

On Wed, Jan 14, 2015 at 2:42 AM, Aravind SV notifications@github.com
wrote:

I checked with one of my forks, and issues can be enabled in the settings
of the repository. @aresok https://github.com/aresok needs to do that.
@aresok https://github.com/aresok?

—
Reply to this email directly or view it on GitHub
#10 (comment)
.

[aresok]

Hi,
I published a release - available here:
https://github.com/aresok/go-maven-poller/releases/tag/v0.3.2
I also make it able to add issues.

Is there something else required to make the release 'complete'?

regards,

Arek Sokołowski

On Wed, Jan 14, 2015 at 8:42 AM, Arek Sokołowski areksokolowski@gmail.com
wrote:

Hi,
currently I'm involved in other things - I will look at the poller in
about a week; sorry for that, regards!

On Wed, Jan 14, 2015 at 2:42 AM, Aravind SV notifications@github.com
wrote:

I checked with one of my forks, and issues can be enabled in the settings
of the repository. @aresok https://github.com/aresok needs to do that.
@aresok https://github.com/aresok?

—
Reply to this email directly or view it on GitHub
#10 (comment)
.

[arvindsv]

Hey @aresok,

I think that's all there is to it. I'm thinking of turning off issues in the original repo, but I don't know who has access to that. I'll leave it for now, and if people start opening issues there, then I'll find out the owner and ask them to turn off issues.

If you need to migrate (create duplicate) issues in your repo, please do that. If the issues at https://github.com/ThoughtWorksInc/go-maven-poller/issues are no longer relevant, I can close them and point them to your repo. Would you like me to do that?

Congratulations on the first release!

Cheers,
Aravind