Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Controls] Add empty state and do cleanup #13

Conversation

andreadelrio
Copy link
Collaborator

Summary

  • Added the empty state (re:graphic, @ryankeairns has already taken a sneak peek at this and we will for sure need to iterate on this before it is ready from a design perspective)

In this PR...
current

Other options explored...
opt_a
opt_b

  • Cleaned up markup for the layout
  • Made changes to match EUI's naming conventions for CSS better, I believe there's still room for improvement here but prefer to get started with this now than later

@ThomThomson pending: hook the "set all widths to default" checkbox in the Manage controls flyout.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@ryankeairns
Copy link

+1 I'd like to get some product feedback on this but that can wait until the parent PR merges.

Copy link
Owner

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks a lot for cleaning up the classes too!

@ThomThomson ThomThomson merged commit e4f5711 into ThomThomson:controls/optionsListSelectionManagement2 Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants