-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
og image update #656
og image update #656
Conversation
chrisdale-io
commented
Sep 28, 2023
- Updating default og image (change of image path)
- Simplifying the previous code implementation in the route file. Replacing complex layering of tiled background texture image over background svg, to simply a background png.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
docs/src/app/og/route.tsx
Outdated
backgroundImage: | ||
'url(https://thinkmill-labs.keystatic.net/keystatic-site/images/km9uvzfb8fqo/og-image-bg)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This background image doesn't seem to be used? so the background is just the colour? I did some investigation and it seems like it's because of vercel/satori#273 and Keystatic Cloud serving webp by default, you should be able to fix that by using https://thinkmill-labs.keystatic.net/keystatic-site/images/km9uvzfb8fqo/og-image-bg?format=png
(from testing that seemed to solve the error from webp but the image still wasn't actually being displayed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Emma, thanks for looking into this. I had a bit of a look and test a few ideas from what you've come back with, with no success. I'm not sure why it's not loading up the background image, as it seemed to work fine from the implementation before the brand update work!?
The previous code for the background image in the original version was this:
backgroundImage: 'url(https://thinkmill-labs.keystatic.net/keystatic-site/images/nt24l5xes6jj/open-graph-bg)',
It's strange, if I add the old code into a fresh OG image playground, the image doesn't load up for 'SVG (Satori)' preview tab, but shows on the 'HTML (Native)' tab (which seems to be what's happening with my new implementation too), but the old code seemed to serve up dynamic og images (again before I adjusted things 🙈):
![Original Dynamic OG Image](https://private-user-images.githubusercontent.com/131427388/271190138-0374e013-bf82-456d-860a-6de2fcf6d636.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1MDIzNTUsIm5iZiI6MTczOTUwMjA1NSwicGF0aCI6Ii8xMzE0MjczODgvMjcxMTkwMTM4LTAzNzRlMDEzLWJmODItNDU2ZC04NjBhLTZkZTJmY2Y2ZDYzNi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQwMzAwNTVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1hYzk5YjFlMzg0YWQ2ZTA2MDg1ODI1NDQ1YTkzNTZjMzBkNDQyNTgyMmU2NjdjOWExNWU2ODQ0N2E2NmFhMDI4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.YK_XHEBD6UAoWmyJ_IIuLuCKaPgehF7k52JQ7WtZoD0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just pushed a commit that seems to fix it, it seems like having an image bigger than the image that's being created made something decide to not render it so resizing the image to be the same size as the output worked