Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs - Layout and responsive navigation #270

Merged
merged 46 commits into from
May 24, 2023
Merged

Docs - Layout and responsive navigation #270

merged 46 commits into from
May 24, 2023

Conversation

jtbrolin
Copy link
Contributor

@jtbrolin jtbrolin commented May 15, 2023 •
edited
Loading

  • Added mobile navigation (hamburger button + slideout)
  • Splitted out navigation.tsx into smaller files in components/navigation for easier consumption
  • Separate RootLayouts for the frontend and the Keystatic Admin UI using route groups, (frontend) + (keystatic)

@changeset-bot
Copy link

changeset-bot bot commented May 15, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: e64f9dd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keystatic ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2023 7:44am
keystatic-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2023 7:44am
voussoir ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2023 7:44am

jtbrolin and others added 4 commits May 16, 2023 16:20
@jtbrolin
Merge branch 'docs' into docs-johan-nav-2
2fdee4e
@BarnabyBishop
Docs: Moved all pages from pages to docs
a59adea 
- Replaced useRouter from next/router to next/navigation
- Updated modal logic to use useRouters basic API
- Removed next-seo as Next13 provides that out of the box
@BarnabyBishop
Added .env.example
c73fcfb
@jtbrolin
Reshuffle
7bdc38c
BarnabyBishop
BarnabyBishop approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@BarnabyBishop BarnabyBishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

@jtbrolin jtbrolin requested a review from BarnabyBishop May 24, 2023 04:58
BarnabyBishop
BarnabyBishop requested changes May 24, 2023
View reviewed changes
Copy link
Contributor

@BarnabyBishop BarnabyBishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny change 🤏

docs/src/app/(keystatic)/layout.tsx Outdated Show resolved Hide resolved
@jtbrolin jtbrolin requested a review from BarnabyBishop May 24, 2023 06:00
ChrisLaneAU
ChrisLaneAU approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@ChrisLaneAU ChrisLaneAU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Well thought out, great job :)

BarnabyBishop
BarnabyBishop approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@BarnabyBishop BarnabyBishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double approved ✅ ✅

ChrisLaneAU
ChrisLaneAU approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@ChrisLaneAU ChrisLaneAU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jtbrolin jtbrolin merged commit 5d229ad into docs May 24, 2023
@jtbrolin jtbrolin deleted the docs-johan-nav-2 branch May 24, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisLaneAU ChrisLaneAU ChrisLaneAU approved these changes

@BarnabyBishop BarnabyBishop BarnabyBishop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtbrolin @BarnabyBishop @ChrisLaneAU