24 rebase3 clean yourself #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tags: feat, doc, test Ongoing feature creation. - Retrieve file path created during inflate - Start to store in a yaml file Issue #24
Tags: feat, test, doc
Why?
- Quarto qmd files are rendered with knitr and can be parsed with {parsermd}, so why not?
What?
- Allow to inflate a qmd file
Issue
issue #160
Tags: feat, doc, test
Why?
- To create a config file for already existing {fusen}, we need not to detect files that should not be deleted
What?
WIP:
- List all files and try to guess origin
- Show the user all files not registered and allow them to manually clean
issue #24
Tags: feat, test, doc Why? - Need to migrate package to the new config file management What? - Allow `df_to_config()` to run on the output of `check_not_registered_files()` Issue #24
Tags: feat, test Why ? - inflate a function having two chunks of example duplicated the roxygen skeleton for that function What? - Multiple example chunks are now combined before being included in the function roxygen example Fix issue #149
Tags: fix, tests Why? - config file needs to be shareable between devs What? - Be sure to transform all paths to relative when possible
Tags: fix, tests Why? - Missing License in a DESCRIPTION is now a note, and not a Warning anymore What? - Add License during test to avoid version mismatch
tags: feat, test, doc Why? - Users would want to use the new config file in the new fusen version, without having to write it themselves if coming from older version or classical package What? - Add `register_all_to_config()` Issue #24
tags: doc Why? - Function is done, it can be inflated in the package What? - Just inflate issue #24
tags: doc
tags: test
Why?
- {roxygen2} now returns warnings if the roxygen skeleton is malformed
What?
- Fix for missing title
- Add {attachment} as remotes while it is out of CRAN
tags: fix, doc, test Why? - All examples need to run properly What? - UPdate flat file for clean_fusen_files - Update documentation to explain how it will work - fix tests and examples Issue #24
tags: fix, test Why? - Full path for MacOS changes on CI What? - Test only relative paths
tags: fix, test, doc Why? - `data.frame()` and `read.csv()` read string as factors in old R versions, preventing them to be used as file path What? - Added stringAsFactors = FALSE everywhere needed issue #24
tags: fix, test Why? - Windows slash and path expand is different from other OS What? - Try to keep relative paths everywhere
tags: feat, doc, test Why? - More info needs to be stored in the config_fusen.yaml file. What? - Allow test to be ok with extra information - TODO: define 'df_to_config()' to only bother about path, R, tests, vignette issue #24
Keep both version when conflicts Issue #24 Merge branch '24-rebase2-clean-yourself' into 24-rebase3-clean-yourself # Conflicts: # R/inflate.R # tests/testthat/test-inflate-part2.R
tags: test Why? - Verify that registering half of the files coming from a common flat file works What? - wip: a test fails. Need to define if `register_all_to_config()` or `df_to_config()` need to account for existing files in the config
tags: fix, feat, test, doc Why? - We may want to register some files after some manual modifications issue #24
tags: chore, feat, test, doc Why? - It is time to integrate the new feature to the mainstream. - The sets a major step towards the cleaning functions to be coming soon (#24) What? - Bump version but keep it as a .9000 to avoid updating vignettes in the pkgdown file - Change path in "do not edit by hand" for a relative path that do not start with "/" issue #24
tags: fix, test Why? - Unit test was failing with interactive
tags: chore Why? - Style package to keep it homogeneous
tags: chore, ci Why? - Actions for check is out-of-date
tags: test Why? - Testing "push on GitHub" with flat teaching template is strategic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ongoing feature creation.
Continue from #169 after update with "main"
df_to_config()to only bother about: path, R, tests and vignettes options in the config_fusen.yaml, to allow extra information to be stored, likestate. And change all existing unit tests accordingly ?register_all_to_config()with abrowser()inflate()to fill config_fusen.yaml fileIssue #24