Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean my name in fill_description() #155

Closed
6 tasks
statnmap opened this issue Jun 20, 2022 · 0 comments · Fixed by #178
Closed
6 tasks

Clean my name in fill_description() #155

statnmap opened this issue Jun 20, 2022 · 0 comments · Fixed by #178
Milestone
v0.5 - Please cle...

Comments

@statnmap
Copy link
Collaborator

statnmap commented Jun 20, 2022 •
edited by FlorenceMounier
Loading

Criteria of validation

Technical

New example used : person("John", "Doe", email = "john@email.me", role = c("aut", "cre"), comment = c(ORCID = "0000-0000-0000-0000"))

To avoid receiving mail from CRAN 😄
@statnmap statnmap added this to the v0.5 milestone Jun 20, 2022
@FlorenceMounier FlorenceMounier changed the title Clean my name in add_description() Clean my name in fill_description() Nov 28, 2022
FlorenceMounier added a commit that referenced this issue Nov 28, 2022
@FlorenceMounier
fix: clear personal name in examples
76a0ac1 
Why?
to avoid receiving mail from CRAN

What?
use John Doe instead of Sebastien Rochette when `fill_description()` is used :
- in flat- & dev-templates
- in main vignette
- in `fill_description()` example

Issue #155
FlorenceMounier added a commit that referenced this issue Nov 28, 2022
@FlorenceMounier
doc: update NEWS issue #155
b33e6bd 
Issue #155
@FlorenceMounier FlorenceMounier linked a pull request Nov 28, 2022 that will close this issue
155 clean my name in add description #178
Merged
statnmap added a commit that referenced this issue Jan 28, 2023
@statnmap
test: clean maintainer's name in unit test
f491f5a 
tags: test

Why?

- Add unit test to check that personal identification will not come back is users templates

issue #155
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.5 - Please clean up your mess!
Development

Successfully merging a pull request may close this issue.

155 clean my name in add description ThinkR-open/fusen
1 participant
@statnmap