Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version annotation for OpenShift #27

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

iamjoemccormick
Copy link
Member

@iamjoemccormick iamjoemccormick commented Feb 29, 2024

Remaining Work

Checklist before merging:

  • Documentation: Has documentation been added for new functionality? Does any existing documentation need to be updated or removed?
  • Tests: Is there adequate test coverage for new functionality? Do any existing tests need to be updated?
  • Dependencies: Does this PR rely on any changes to dependencies? If so has the go.mod or equivalent been updated to point at a version that contains the related changes?
  • Git Hygiene: Is the commit history squashed down reasonably?

Which issue(s) does this PR address?

None

Does this PR depend on any other PRs to be merged first?

No

What does this PR do / why do we need it?

OpenShift started requiring bundles to specify what versions of OpenShift are supported and the fact we did not specify this was caught when submitting the bundle for v1.6.0. Adding the version annotation does not appear to be directly supported through operator-sdk, so a hack script was added to add it in the appropriate places after generating the bundle.

Note OpenShift has not been officially supported since v1.5.0, but we still publish bundles as a convenience for anyone using OpenShift that wants to run the driver "at their own risk". We plan to continue doing so long as the work needed to "unofficially" support OpenShift is fairly minimal.

What are the next steps after this PR?

All work items for this task are complete with this PR.

@iamjoemccormick iamjoemccormick self-assigned this Feb 29, 2024
@iamjoemccormick iamjoemccormick merged commit 8792f2a into master Mar 6, 2024
20 checks passed
@iamjoemccormick iamjoemccormick deleted the iamjoemccormick/add-openshift-version branch March 6, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant