Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage report #9

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Fix coverage report #9

merged 1 commit into from
Nov 28, 2023

Conversation

Theshedman
Copy link
Owner

The coverage repost suppose to happen once a PR is raised. But it happens after a push is made to the main/beta branch there by not giving us metrics on the quality of the PR.

This PR is a fix for that which forces it to generate coverage on every PR.

The commit modifies the trigger event for the coverage workflow in Github actions. Instead of triggering on push events, it now triggers on pull request events. This affects both the 'main' and 'beta' branches as defined in coverage.yaml.
@Theshedman Theshedman added the bug Something isn't working label Nov 28, 2023
Copy link

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 97.3% 144/148
🟢 Branches 92.31% 36/39
🟢 Functions 100% 59/59
🟢 Lines 97.24% 141/145

Test suite run success

63 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 8e143fd

Copy link
Collaborator

@UcheSylvester UcheSylvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@UcheSylvester UcheSylvester merged commit ebb8648 into main Nov 28, 2023
2 checks passed
Copy link

🎉 This PR is included in version 1.3.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants