Skip to content

Commit

Permalink
Merge pull request #4 from Theshedman/fix/space-character-validator
Browse files Browse the repository at this point in the history
feat(NoSpaceCharacters): Rename SpaceCharacterValidator to NoSpaceCharacterValidator and update tests
  • Loading branch information
Theshedman authored Nov 27, 2023
2 parents 519279e + 5e8294d commit c2565a6
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 11 deletions.
6 changes: 3 additions & 3 deletions src/password/usages/PasswordValidatorManagerUsage.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { LowerCaseValidator } from "../validator/LowerCaseValidator.js";
import { MinLengthValidator } from "../validator/MinLengthValidator.js";
import { PasswordValidatorManager } from "../validator/PasswordValidatorManager.js";
import { SpaceCharacterValidator } from "../validator/SpaceCharacterValidator.js";
import { NoSpaceCharacterValidator } from "../validator/NoSpaceCharacterValidator.js";
import { SpecialCharacterValidator } from "../validator/SpecialCharacterValidator.js";
import { UpperCaseValidator } from "../validator/UpperCaseValidator.js";

Expand All @@ -11,9 +11,9 @@ const minLength = new MinLengthValidator(6);
const specialChar = new SpecialCharacterValidator(1);
const uppercase = new UpperCaseValidator(1);
const lowercase = new LowerCaseValidator(1);
const space = new SpaceCharacterValidator();
const noSpace = new NoSpaceCharacterValidator();

pm.register(minLength, specialChar, uppercase, lowercase, space);
pm.register(minLength, specialChar, uppercase, lowercase, noSpace);

const results = pm.validate("a*bcUdsdfdsf");

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { ValidationResult } from "./ValidationResult.js";
import { PasswordValidator } from "./PasswordValidator.js";
import { ValidatorCategory } from "./ValidatorCategory.js";

export class SpaceCharacterValidator extends PasswordValidator {
export class NoSpaceCharacterValidator extends PasswordValidator {
constructor() {
super(ValidatorCategory.PATTERN_MATCHER, 0);
}
Expand Down
2 changes: 1 addition & 1 deletion src/password/validator/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export * from "./LowerCaseValidator.js";
export * from "./MaxLengthValidator.js";
export * from "./UpperCaseValidator.js";
export * from "./MinLengthValidator.js";
export * from "./SpaceCharacterValidator.js";
export * from "./NoSpaceCharacterValidator.js";
export * from "./PasswordValidatorManager.js";
export * from "./SpecialCharacterValidator.js";
export * from "./PasswordValidatorConflictException.js";
12 changes: 6 additions & 6 deletions src/test/PasswordValidatorManager.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { MinLengthValidator } from "../password/validator/MinLengthValidator.js"
import { MaxLengthValidator } from "../password/validator/MaxLengthValidator.js";
import { LowerCaseValidator } from "../password/validator/LowerCaseValidator.js";
import { UpperCaseValidator } from "../password/validator/UpperCaseValidator.js";
import { SpaceCharacterValidator } from "../password/validator/SpaceCharacterValidator.js";
import { NoSpaceCharacterValidator } from "../password/validator/NoSpaceCharacterValidator.js";
import { PasswordValidatorManager } from "../password/validator/PasswordValidatorManager.js";
import { SpecialCharacterValidator } from "../password/validator/SpecialCharacterValidator.js";
import { PasswordValidatorConflictException } from "../password/validator/PasswordValidatorConflictException.js";
Expand Down Expand Up @@ -232,13 +232,13 @@ describe.each([
{ password: "WldkKF", expected: true },
{ password: "kdvAd! #k", rule: 4, expected: false },
{ password: "K,dslJG#<>HDmd.kL", rule: 5, expected: true },
])("Space Character Validation", ({ password, expected }): void => {
it(`should validate Space Characters in: "${password}"`, (): void => {
])("No Space Character Validation", ({ password, expected }): void => {
it(`should validate No Space Characters in: "${password}"`, (): void => {
const pm: ValidatorManager = new PasswordValidatorManager();

const spaceCharacterValidator: PasswordValidator =
new SpaceCharacterValidator();
pm.register(spaceCharacterValidator);
const noSpaceCharacterValidator: PasswordValidator =
new NoSpaceCharacterValidator();
pm.register(noSpaceCharacterValidator);

const actual: ValidationResult = pm.validate(password);

Expand Down

0 comments on commit c2565a6

Please sign in to comment.