Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mission - Rework Reinforcements #673

Merged
merged 4 commits into from
Mar 19, 2024
Merged

Mission - Rework Reinforcements #673

merged 4 commits into from
Mar 19, 2024

Conversation

Mike-MF
Copy link
Member

@Mike-MF Mike-MF commented Mar 19, 2024

Requires (#675)

When merged this pull request will:

  • Rework Reinforcements to take array instead of singular group.
  • Removes Hunt integration.
  • Sets default state to true.

Tested, working. (Including BWC for old method)

@Mike-MF Mike-MF marked this pull request as ready for review March 19, 2024 05:45
@Mike-MF Mike-MF added this to the 2.2.0 milestone Mar 19, 2024
@Mike-MF Mike-MF requested a review from jonpas March 19, 2024 08:27
@jonpas jonpas changed the title Mission - Rework reinforcements Mission - Rework Reinforcements Mar 19, 2024
@jonpas
Copy link
Member

jonpas commented Mar 19, 2024

Removes Hunt integration

Why? Was it ever used?

@Mike-MF
Copy link
Member Author

Mike-MF commented Mar 19, 2024

I used it once, a long time ago.

I regret making hunt, people just look at it as something you should always run on every group ever. Which is a terrible idea and why it's limited to 6 groups, having it integrated into this was originally designed for ease of use but nobody ever bothered besides me during a test.

I'd rather this just be what it's meant to be with no excess.

@jonpas
Copy link
Member

jonpas commented Mar 19, 2024

Do one thing well.

@jonpas jonpas merged commit ab0203b into master Mar 19, 2024
3 checks passed
@jonpas jonpas deleted the reinforcements-rework branch March 19, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants